Skip to content

[core] Fix the error message when storage is not set.#33581

Merged
fishbone merged 1 commit into
ray-project:masterfrom
fishbone:fix-wf-error-msg
Mar 24, 2023
Merged

[core] Fix the error message when storage is not set.#33581
fishbone merged 1 commit into
ray-project:masterfrom
fishbone:fix-wf-error-msg

Conversation

@fishbone
Copy link
Copy Markdown
Contributor

Signed-off-by: Yi Cheng 74173148+iycheng@users.noreply.github.com

Why are these changes needed?

Due to incorrect setup, storage is passed even it's None and in the worker it'll be treated as "None" instead of None and thus it'll give wrong error message which mislead the users.

This PR fixed it by passing the storage only when it's setup.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Yi Cheng <74173148+iycheng@users.noreply.github.com>
@fishbone
Copy link
Copy Markdown
Contributor Author

@scv119 @suquark could you take a look at this? I think it should be included in 2.4 release.

@suquark
Copy link
Copy Markdown
Member

suquark commented Mar 23, 2023

@iycheng This is nice catch & nice fix! Thanks a lot!

@fishbone fishbone merged commit d8eff4e into ray-project:master Mar 24, 2023
@fishbone fishbone deleted the fix-wf-error-msg branch March 24, 2023 02:36
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
)

Due to incorrect setup, storage is passed even it's None and in the worker it'll be treated as "None" instead of None and thus it'll give wrong error message which mislead the users.

This PR fixed it by passing the storage only when it's setup.

Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
)

Due to incorrect setup, storage is passed even it's None and in the worker it'll be treated as "None" instead of None and thus it'll give wrong error message which mislead the users.

This PR fixed it by passing the storage only when it's setup.

Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Workflows] pyarrow.lib.ArrowInvalid: URI has empty scheme: 'None'

3 participants