Skip to content

[Train] Empty cache on the correct device#33603

Merged
Yard1 merged 1 commit into
ray-project:masterfrom
Yard1:torch_empty_cache_device
Mar 23, 2023
Merged

[Train] Empty cache on the correct device#33603
Yard1 merged 1 commit into
ray-project:masterfrom
Yard1:torch_empty_cache_device

Conversation

@Yard1
Copy link
Copy Markdown
Member

@Yard1 Yard1 commented Mar 22, 2023

Why are these changes needed?

Related issue number

Closes #30809

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1 Yard1 requested a review from amogkam March 23, 2023 02:15
@Yard1 Yard1 marked this pull request as ready for review March 23, 2023 02:15
@Yard1 Yard1 merged commit df35463 into ray-project:master Mar 23, 2023
@Yard1 Yard1 deleted the torch_empty_cache_device branch March 23, 2023 21:06
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Train] Cuda OOM on shutdown

2 participants