[Data] [2/3] Async iter_batches: Add interfaces and helper functions#33605
Merged
Conversation
amogkam
requested review from
c21,
clarkzinzow,
ericl,
jianoaix,
jjyao and
scv119
as code owners
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
ericl
requested changes
Mar 23, 2023
Contributor
ericl
left a comment
ericl
left a comment
There was a problem hiding this comment.
A few quick comments, will look in the implementation more later today.
…atches-2 Signed-off-by: amogkam <amogkamsetty@yahoo.com>
ericl
reviewed
Mar 23, 2023
ericl
added
the
@author-action-required
clarkzinzow
requested changes
Mar 23, 2023
Contributor
clarkzinzow
left a comment
clarkzinzow
left a comment
There was a problem hiding this comment.
Initial pass, one main thing to block on is I really think that the local shuffling has to happen after block resolution, otherwise that breaks the local shuffling semantics in a big way.
clarkzinzow
reviewed
Mar 23, 2023
ericl
reviewed
Mar 24, 2023
Contributor
|
Looks a lot cleaner. Remaining concerns are (1) documenting the big picture strategy clearly, and (2) fixing the possible error in over-prefetching. |
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
ericl
approved these changes
Mar 24, 2023
clarkzinzow
reviewed
Mar 24, 2023
clarkzinzow
approved these changes
Mar 24, 2023
Contributor
clarkzinzow
left a comment
clarkzinzow
left a comment
There was a problem hiding this comment.
Approving to unblock since I mostly have nits and I'll soon be offline until Monday!
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Contributor
Author
|
failing tests are also failing on master, going to merge |
amogkam
added
tests-ok
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…ay-project#33605) Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…ay-project#33605) Signed-off-by: Jack He <jackhe2345@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the necessary helper functions for each step of
iter_batchesWhy are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.