Skip to content

[Datasets] Correct link of batch inference#33614

Merged
richardliaw merged 1 commit into
ray-project:masterfrom
c21:landing-page
Mar 23, 2023
Merged

[Datasets] Correct link of batch inference#33614
richardliaw merged 1 commit into
ray-project:masterfrom
c21:landing-page

Conversation

@c21
Copy link
Copy Markdown
Contributor

@c21 c21 commented Mar 23, 2023

Why are these changes needed?

It would be better to redirect users to batch inference use case page, instead of https://docs.ray.io/en/master/data/transforming-datasets.html , which is a general page to explain tranformation APIs to users. Users might be confused when redirected to this page.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Cheng Su <scnju13@gmail.com>
Copy link
Copy Markdown
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos for maintaining cross-links, @c21 !

LGTM

@richardliaw richardliaw merged commit 58c3f74 into ray-project:master Mar 23, 2023
@c21 c21 deleted the landing-page branch March 23, 2023 22:24
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants