Skip to content

Convert pending_notifications to STL#484

Merged
robertnishihara merged 7 commits intoray-project:masterfrom
pcmoritz:plasma-notifications
Apr 24, 2017
Merged

Convert pending_notifications to STL#484
robertnishihara merged 7 commits intoray-project:masterfrom
pcmoritz:plasma-notifications

Conversation

@pcmoritz
Copy link
Copy Markdown
Contributor

@pcmoritz pcmoritz commented Apr 24, 2017

This makes more progress on #404.

@AmplabJenkins
Copy link
Copy Markdown

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/612/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/613/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/614/
Test PASSed.

Comment thread src/plasma/plasma_store.cc Outdated
NotificationQueue *queue;
HASH_FIND_INT(plasma_state->pending_notifications, &client_sock, queue);
CHECK(queue != NULL);
NotificationQueue *queue = &plasma_state->pending_notifications[client_sock];
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copying plasma_state->pending_notifications[client_sock].

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@AmplabJenkins
Copy link
Copy Markdown

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/616/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/617/
Test FAILed.

@robertnishihara robertnishihara merged commit 8194b71 into ray-project:master Apr 24, 2017
@robertnishihara robertnishihara deleted the plasma-notifications branch April 24, 2017 21:41
Myasuka pushed a commit to Myasuka/ray that referenced this pull request Aug 11, 2025
aslonnie pushed a commit that referenced this pull request Apr 17, 2026
…ob limit (#62736)

Buildkite rejects pipeline uploads above an organization-level job limit
(500 at time of writing) with "Pipeline upload rejected: The number of
jobs in this upload exceeds your organization limit of 500." The release
pipeline's release_tests.json has grown past that; the previous "step
dependencies not found" failure had been masking it.

custom_image_build_and_test_init now splits the computed steps into
batches of at most --max-jobs-per-upload jobs (default 450 for headroom)
and writes each batch to .buildkite/release/release_tests_<i>.json.
Groups are atomic — a single group that exceeds the limit raises,
matching the approach taken in rayci (ray-project/rayci#483, #484).
custom-image-build-and-test-init.sh iterates the chunks and uploads each
in order so dependencies between steps in different chunks still
resolve.

Signed-off-by: andrew <andrew@anyscale.com>
HLDKNotFound pushed a commit to chichic21039/ray that referenced this pull request Apr 22, 2026
…ob limit (ray-project#62736)

Buildkite rejects pipeline uploads above an organization-level job limit
(500 at time of writing) with "Pipeline upload rejected: The number of
jobs in this upload exceeds your organization limit of 500." The release
pipeline's release_tests.json has grown past that; the previous "step
dependencies not found" failure had been masking it.

custom_image_build_and_test_init now splits the computed steps into
batches of at most --max-jobs-per-upload jobs (default 450 for headroom)
and writes each batch to .buildkite/release/release_tests_<i>.json.
Groups are atomic — a single group that exceeds the limit raises,
matching the approach taken in rayci (ray-project/rayci#483, ray-project#484).
custom-image-build-and-test-init.sh iterates the chunks and uploads each
in order so dependencies between steps in different chunks still
resolve.

Signed-off-by: andrew <andrew@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants