Skip to content

[Autoscaler] Update YAML example for CoordinatorSenderNodeProvider#51292

Merged
jjyao merged 3 commits into
ray-project:masterfrom
nadongjun:autoscaler/local
Mar 14, 2025
Merged

[Autoscaler] Update YAML example for CoordinatorSenderNodeProvider#51292
jjyao merged 3 commits into
ray-project:masterfrom
nadongjun:autoscaler/local

Conversation

@nadongjun
Copy link
Copy Markdown
Contributor

@nadongjun nadongjun commented Mar 12, 2025

Why are these changes needed?

This PR updates the YAML example for the CoordinatorSenderNodeProvider (e.g., example-minimal-automatic.yaml) to reflect the latest changes and prevent parameter errors when running the example.

The following parameters have been added to the YAML example to ensure proper functionality and alignment with the updated configuration:

initialization_commands
setup_commands
head_setup_commands
worker_setup_commands
available_node_types
head_node_type
head_start_ray_commands
worker_start_ray_commands
file_mounts
cluster_synced_files
file_mounts_sync_continuously
rsync_exclude
rsync_filter

Related issue number

#51291

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Dongjun Na <kmu5544616@gmail.com>
@nadongjun nadongjun requested a review from a team as a code owner March 12, 2025 06:57
@jcotant1 jcotant1 added the core Issues that should be addressed in Ray Core label Mar 12, 2025
@dayshah
Copy link
Copy Markdown
Contributor

dayshah commented Mar 12, 2025

https://docs.ray.io/en/latest/ray-contribute/development.html#pre-commit-hooks Hey looks like pre-commit is failing. Could you follow these directions and commit again. Ty!

Signed-off-by: Dongjun Na <kmu5544616@gmail.com>
@nadongjun
Copy link
Copy Markdown
Contributor Author

@dayshah Set up pre-commit and committed again. Thanks!

@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Mar 14, 2025
@jjyao jjyao enabled auto-merge (squash) March 14, 2025 16:18
@jjyao jjyao merged commit 185e69e into ray-project:master Mar 14, 2025
park12sj pushed a commit to park12sj/ray that referenced this pull request Mar 18, 2025
dhakshin32 pushed a commit to dhakshin32/ray that referenced this pull request Mar 27, 2025
…ay-project#51292)

Signed-off-by: Dongjun Na <kmu5544616@gmail.com>
Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-backlog core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants