[release-automation] Add option to add build tag when uploading wheels to pypi#51517
Merged
[release-automation] Add option to add build tag when uploading wheels to pypi#51517
Conversation
aslonnie
reviewed
Mar 19, 2025
| commit_hash: The commit hash of the green commit. | ||
| ray_version: The version of Ray. | ||
| directory_path: The directory to download the wheels to. | ||
| build_tag: The build tag to add to the downloaded wheels. |
Collaborator
There was a problem hiding this comment.
where is this arg? wrong place?
Contributor
Author
There was a problem hiding this comment.
oh yes it used to be there before I moved it.. but I forgot to delete the docstring
aslonnie
reviewed
Mar 19, 2025
Collaborator
aslonnie
left a comment
aslonnie
left a comment
There was a problem hiding this comment.
nice!
could you fix the lints?
aslonnie
approved these changes
Mar 21, 2025
dhakshin32
pushed a commit
to dhakshin32/ray
that referenced
this pull request
Mar 27, 2025
…s to pypi (ray-project#51517) - Add helper function to add build tag (e.g. `-1`) right after Ray version in the wheel name, in cases where original wheels uploaded to pypi/test pypi are corrupted. --------- Signed-off-by: kevin <kevin@anyscale.com> Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-1) right after Ray version in the wheel name, in cases where original wheels uploaded to pypi/test pypi are corrupted.