Skip to content

Comments

Move experimental and OOM tests to core builds#51525

Merged
edoakes merged 4 commits intoray-project:masterfrom
edoakes:eoakes/core-doctest
Mar 21, 2025
Merged

Move experimental and OOM tests to core builds#51525
edoakes merged 4 commits intoray-project:masterfrom
edoakes:eoakes/core-doctest

Conversation

@edoakes
Copy link
Collaborator

@edoakes edoakes commented Mar 19, 2025

Why are these changes needed?

They're owned by core team.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

edoakes added 2 commits March 19, 2025 09:52
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes requested a review from aslonnie March 19, 2025 14:59
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Mar 19, 2025
@edoakes edoakes enabled auto-merge (squash) March 19, 2025 15:00
edoakes added 2 commits March 20, 2025 10:32
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@github-actions github-actions bot disabled auto-merge March 20, 2025 15:35
@edoakes edoakes requested a review from aslonnie March 20, 2025 18:03
@edoakes edoakes enabled auto-merge (squash) March 20, 2025 22:13
--skip-ray-installation
# doc memory pressure example
- bazel run //ci/ray_ci:test_in_docker -- //doc/... core
--only-tags mem_pressure
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought they will need --build-name doctestbuild, but if it works, it is fine.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea nothing special in the test, just ray core APIs, so should be good

@edoakes edoakes merged commit 46e8c25 into ray-project:master Mar 21, 2025
6 checks passed
dhakshin32 pushed a commit to dhakshin32/ray that referenced this pull request Mar 27, 2025
They're owned by core team.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-backlog go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants