Conversation
Signed-off-by: Abrar Sheikh <abrar@anyscale.com>
edoakes
reviewed
Mar 25, 2025
Collaborator
edoakes
left a comment
edoakes
left a comment
There was a problem hiding this comment.
believe there are some tests that need to be updated (see test_metrics.py)
Contributor
Author
There are currently no tests for disconnect and timeout in |
Collaborator
Oof! Yes we should add some basic ones |
Signed-off-by: Abrar Sheikh <abrar@anyscale.com>
Signed-off-by: Abrar Sheikh <abrar@anyscale.com>
edoakes
reviewed
Mar 28, 2025
Signed-off-by: Abrar Sheikh <abrar@anyscale.com>
edoakes
reviewed
Mar 31, 2025
zcin
reviewed
Mar 31, 2025
Signed-off-by: Abrar Sheikh <abrar@anyscale.com>
zcin
approved these changes
Apr 1, 2025
Contributor
|
Is this ready to merge @abrarsheikh? |
Contributor
Author
yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this change aligns the status codes for timeouts/disconnect between tracing and proxy logs
in the process of working on this PR, I realized that We don't have request_timeout_s for gRPC like we do for HTTP. Currently, gRPC relies on an environment variable for request timeouts. We should deprecate the environment variable and introduce a new attribute in the gRPC options schema to configure request timeouts explicitly. #51761