Skip to content

Comments

[core] Propagate source location of error status#51665

Closed
dentiny wants to merge 3 commits intoray-project:masterfrom
dentiny:hjiang/propagate-error-location
Closed

[core] Propagate source location of error status#51665
dentiny wants to merge 3 commits intoray-project:masterfrom
dentiny:hjiang/propagate-error-location

Conversation

@dentiny
Copy link
Contributor

@dentiny dentiny commented Mar 25, 2025

Current error status is not clear:

[2025-03-25 05:48:00,979 C 1380797 1380797] cgroup_setup.cc:176:  Check failed: InitializeCgroupV2Directory(directory, node_id) Status not OK: Invalid: Failed to open cgroup file  
*** StackTrace Information ***
/home/ubuntu/.cache/bazel/_bazel_ubuntu/2139a9ac91f0a6877cfd4920666e807a/execroot/com_github_ray_project_ray/bazel-out/k8-opt/bin/src/ray/common/cgroup/test/../../../../../_solib_k8/libsrc_Sray_Sutil_Sliblogging.so(_ZN3raylsERSoRKNS_10StackTraceE+0x38) [0x7fce9ec73928] ray::operator<<()
/home/ubuntu/.cache/bazel/_bazel_ubuntu/2139a9ac91f0a6877cfd4920666e807a/execroot/com_github_ray_project_ray/bazel-out/k8-opt/bin/src/ray/common/cgroup/test/../../../../../_solib_k8/libsrc_Sray_Sutil_Sliblogging.so(_ZN3ray6RayLogD1Ev+0x67) [0x7fce9ec77777] ray::RayLog::~RayLog()

As shown in the above example, it only shows the function name where the error status is checked, but not the place error happens.

Updated error stacktrace after this PR:

src/ray/common/test/status_test.cc:28: Invalid status

Signed-off-by: dentiny <dentinyhao@gmail.com>
@dentiny dentiny added the go add ONLY when ready to merge, run all tests label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-backlog go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants