Skip to content

[core] Lazily subscribe to node changes from workers#51718

Closed
dayshah wants to merge 9 commits intoray-project:masterfrom
dayshah:lazy-worker-node-sub
Closed

[core] Lazily subscribe to node changes from workers#51718
dayshah wants to merge 9 commits intoray-project:masterfrom
dayshah:lazy-worker-node-sub

Conversation

@dayshah
Copy link
Contributor

@dayshah dayshah commented Mar 26, 2025

Why are these changes needed?

This should result in significantly increased scalability in terms of # of nodes / workers that can be supported by the GCS. The main gcs thread spends a lot of time on GetAllNodeInfo requests and we make one of these requests every single time a worker subscribes to node changes to get the current state of all nodes. Every worker doesn't actually need to be aware of the state of all other nodes, only workers that are the "owners" of objects and task submitters need to be aware of this. Very few workers are either of these things. In most cases it's just the driver (which is why we always subscribe if the worker is the driver here).

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: dayshah <dhyey2019@gmail.com>
@dayshah dayshah added go add ONLY when ready to merge, run all tests and removed go add ONLY when ready to merge, run all tests labels Mar 26, 2025
dayshah added 3 commits March 26, 2025 19:24
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: dayshah <dhyey2019@gmail.com>
@dayshah dayshah added the go add ONLY when ready to merge, run all tests label Mar 27, 2025
dayshah added 3 commits March 27, 2025 15:48
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: dayshah <dhyey2019@gmail.com>
@stale
Copy link

stale bot commented Apr 29, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Apr 29, 2025
@dayshah dayshah removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Apr 29, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com>
@github-actions
Copy link

github-actions bot commented Jun 7, 2025

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jun 7, 2025
@dayshah dayshah removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jun 7, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jun 23, 2025
@dayshah dayshah removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jun 23, 2025
Signed-off-by: dayshah <dhyey2019@gmail.com>
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jul 14, 2025
@dayshah dayshah closed this Jul 17, 2025
@dayshah dayshah deleted the lazy-worker-node-sub branch July 17, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests stale The issue is stale. It will be closed within 7 days unless there are further conversation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments