[core] More moves and less locking on task receiving path #52485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dayshah <dhyey2019@gmail.com>
edoakes
reviewed
Apr 21, 2025
Collaborator
edoakes
left a comment
edoakes
left a comment
There was a problem hiding this comment.
mostly questions for my own understanding
| RAY_LOG(INFO).WithField(placement_group_id) | ||
| << "Submitting Placement Group creation to GCS"; | ||
| const auto status = | ||
| auto status = |
Contributor
Author
There was a problem hiding this comment.
We're returning status, if you return a const you're killing the NRVO (named return value optimization) the compiler would normally do.
Contributor
Author
There was a problem hiding this comment.
Correction: nrvo isn't guaranteed here and we may be doing an implicit move. And the const removes the implicit move
edoakes
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Some extra moves and linting around task receiver and core worker files. Also reader locking instead of writer locking on the job config setup on every task.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.