-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[data] Adding in batch inference mock pipeline release test #52616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data] Adding in batch inference mock pipeline release test #52616
Conversation
release/release_data_tests.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Optionally for future reference): we can use the variants syntax to minimize duplication
ray/release/release_data_tests.yaml
Lines 211 to 232 in 251a131
| - name: distributed_training | |
| working_dir: nightly_tests | |
| cluster: | |
| byod: | |
| post_build_script: byod_install_mosaicml.sh | |
| cluster_compute: dataset/multi_node_train_16_workers.yaml | |
| run: | |
| timeout: 3600 | |
| script: > | |
| python dataset/multi_node_train_benchmark.py --num-workers 16 --file-type parquet | |
| --target-worker-gb 50 --use-gpu | |
| variations: | |
| - __suffix__: regular | |
| - __suffix__: chaos | |
| run: | |
| prepare: > | |
| python setup_chaos.py --kill-interval 200 --max-to-kill 1 --task-names | |
| "_RayTrainWorker__execute.get_next" | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aslonnie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:) thank you
you might want to double check again if the release test works
Signed-off-by: Matthew Owen <mowen@anyscale.com>
Signed-off-by: Matthew Owen <mowen@anyscale.com>
Signed-off-by: Matthew Owen <mowen@anyscale.com>
Signed-off-by: Matthew Owen <mowen@anyscale.com>
Signed-off-by: Matthew Owen <mowen@anyscale.com>
Signed-off-by: Matthew Owen <mowen@anyscale.com>
503d678 to
0cb639a
Compare
Signed-off-by: Matthew Owen <mowen@anyscale.com>
Signed-off-by: Matthew Owen <mowen@anyscale.com>
Signed-off-by: Matthew Owen <mowen@anyscale.com>
Signed-off-by: Matthew Owen <mowen@anyscale.com>
0cb639a to
09f8a7a
Compare
## Why are these changes needed? We want to add a release test that will be used to model performance on a batch inference image pipeline. This is meant to more accurately model a realistic user pipeline. This will be used to track our improvement on this workload and more broadly our improvement on batch inference with images with and without spot nodes. ## Related issue number <!-- For example: "Closes #1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Matthew Owen <mowen@anyscale.com> Co-authored-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: jhsu <jhsu@anyscale.com>
Why are these changes needed?
We want to add a release test that will be used to model performance on a batch inference image pipeline. This is meant to more accurately model a realistic user pipeline. This will be used to track our improvement on this workload and more broadly our improvement on batch inference with images with and without spot nodes.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.