Skip to content

Conversation

@eicherseiji
Copy link
Contributor

@eicherseiji eicherseiji commented May 28, 2025

Why are these changes needed?

RayPrometheusStatLogger inherits from StatLoggerBase in vLLM. We need to make sure this code path is exercised to ensure our implementation stays compliant with vLLM's abstract base class.

This is needed until vLLM 0.9.0, when we will switch to the implementation which landed in vllm-project/vllm#17925.

Related issue number

Guard against issue #53335, close LLM-1969

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Seiji Eicher <seiji@anyscale.com>
@eicherseiji eicherseiji requested a review from a team as a code owner May 28, 2025 01:55
@eicherseiji eicherseiji self-assigned this May 28, 2025
@eicherseiji eicherseiji added the go add ONLY when ready to merge, run all tests label May 28, 2025
Copy link
Member

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kouroshHakha
Copy link
Contributor

We should proabably run this as a release test because the compute compatibility is limited on premerge. I don't think it is easy to change the hw of the premerge tests. but it's easy todo for release tests.

@kouroshHakha kouroshHakha changed the title Add test to guard against upstream StatLogger changes [Serve.llm] Add test to guard against upstream StatLogger changes May 28, 2025
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
@kouroshHakha kouroshHakha merged commit fbaad73 into ray-project:master May 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Serve.llm] Can't instantiate abstract class RayPrometheusStatLogger with abstract method log_engine_initialized

3 participants