Skip to content

Conversation

@landscapepainter
Copy link
Contributor

Why are these changes needed?

We need to keep on track of the users using pydantic version < 2 so we can make complete migration to use >= 2 after confirming there aren't any.

@landscapepainter landscapepainter requested review from a team, pcmoritz and thomasdesr as code owners June 12, 2025 21:26
Signed-off-by: doyoung <doyoung@anyscale.com>
@edoakes
Copy link
Collaborator

edoakes commented Jun 12, 2025

@landscapepainter can we expand this to all ray applications, not just serve? We might be able to simplify things for ray in general by not handling pydantic <2.0.

You can still get the same info that you have here by filtering to library usage of serve + pydantic < 2.0

// Whether custom request router was used ("1" if used)
SERVE_CUSTOM_REQUEST_ROUTER_USED = 32;
// Whether Serve is running under pydantic < 2 ("1" if true)
SERVE_PYDANTIC_V2_UNUSED = 33;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SERVE_PYDANTIC_V2_UNUSED = 33;
SERVE_PYDANTIC_V1_USED = 33;

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jun 27, 2025
@github-actions
Copy link

This pull request has been automatically closed because there has been no more activity in the 14 days
since being marked stale.

Please feel free to reopen or open a new pull request if you'd still like this to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for your contribution!

@github-actions github-actions bot closed this Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale The issue is stale. It will be closed within 7 days unless there are further conversation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants