[train] Fix release test missing data key #53963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR works around a missing class-partitioned validation directory by using the training directory as a temporary fallback and flags the need for a proper fix.
- Switched
val_dirassignment to reuse the training directory - Added a TODO comment to revisit loading logic for the validation dataset
srinathk10
approved these changes
Jun 23, 2025
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
The Jpeg dataset validation directory doesn't have a directory structure with the class names, which is an assumption of the `read_images` code right now. Switches to using a subset of the training dataset instead and adds a TODO to fix the validation dataset loading. Signed-off-by: Justin Yu <justinvyu@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
The Jpeg dataset validation directory doesn't have a directory structure with the class names, which is an assumption of the `read_images` code right now. Switches to using a subset of the training dataset instead and adds a TODO to fix the validation dataset loading. Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Jpeg dataset validation directory doesn't have a directory structure with the class names, which is an assumption of the
read_imagescode right now. Switches to using a subset of the training dataset instead and adds a TODO to fix the validation dataset loading.