[release test] always use images from previous pipeline steps#56029
Merged
[release test] always use images from previous pipeline steps#56029
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the release testing process to use pre-built images from previous pipeline steps instead of building them on-the-fly. This simplifies the logic by removing image building code and instead adding checks for image existence. The changes look good and significantly simplify the codebase. My main feedback is to update a docstring to reflect the new behavior of a function whose role has changed.
Comment on lines
53
to
55
| """ | ||
| Builds the Anyscale BYOD images for the given tests. | ||
| """ |
Contributor
There was a problem hiding this comment.
The function build_anyscale_base_byod_images no longer builds images, making its name misleading. While renaming it (e.g., to get_and_verify_anyscale_base_byod_images) would be ideal, at the very least, the docstring should be updated to accurately describe its new behavior of verifying image existence.
Suggested change
| """ | |
| Builds the Anyscale BYOD images for the given tests. | |
| """ | |
| """ | |
| Verifies that all required Anyscale BYOD base images for the given tests exist | |
| and returns a sorted list of image names. | |
| """ |
so that they will never need to do the explicit waiting anymore Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
never try to build on one's own Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie
force-pushed
the
lonnie-250827-imgdep2
branch
from
1474766 to
5b8a6c0
Compare
khluu
approved these changes
Aug 29, 2025
gangsf
pushed a commit
to gangsf/ray
that referenced
this pull request
Sep 2, 2025
…oject#56029) never try to build on one's own --------- Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Gang Zhao <gang@gang-JQ62HD2C37.local>
sampan-s-nayak
pushed a commit
to sampan-s-nayak/ray
that referenced
this pull request
Sep 8, 2025
…oject#56029) never try to build on one's own --------- Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: sampan <sampan@anyscale.com>
jugalshah291
pushed a commit
to jugalshah291/ray_fork
that referenced
this pull request
Sep 11, 2025
…oject#56029) never try to build on one's own --------- Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
wyhong3103
pushed a commit
to wyhong3103/ray
that referenced
this pull request
Sep 12, 2025
…oject#56029) never try to build on one's own --------- Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: yenhong.wong <yenhong.wong@grabtaxi.com>
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
never try to build on one's own --------- Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…oject#56029) never try to build on one's own --------- Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
never try to build on one's own