[core] Split gcs_autoscaler_state_manager out from gcs_server_lib#56053
Merged
edoakes merged 150 commits intoray-project:masterfrom Aug 29, 2025
Merged
[core] Split gcs_autoscaler_state_manager out from gcs_server_lib#56053edoakes merged 150 commits intoray-project:masterfrom
gcs_autoscaler_state_manager out from gcs_server_lib#56053edoakes merged 150 commits intoray-project:masterfrom
Conversation
…es/gcs-node-manager-target
…es/gcs-resource-manager
…es/gcs-resource-manager
…es/node-manager-gcs-server
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a significant refactoring that splits gcs_autoscaler_state_manager and other components out of the large gcs_server_lib. The introduction of a service handler interface layer is a great improvement for modularity and testability. The changes are extensive, touching many files including build definitions and tests, but they appear to be consistent and well-executed. I've found a few minor issues with redundant header includes that should be cleaned up for better code hygiene and potentially faster compile times.
| #include "ray/util/counter_map.h" | ||
| #include "ray/util/event.h" | ||
| #include "ray/util/thread_checker.h" | ||
| #include "src/ray/protobuf/gcs_service.pb.h" |
Contributor
There was a problem hiding this comment.
This header is likely redundant. grpc_service_interfaces.h (included on line 35) includes gcs_service.grpc.pb.h, which in turn should include gcs_service.pb.h. Please remove this include if it's not directly needed.
…es/gcs-autoscaler-manager
…es/gcs-actor-manager
…es/gcs-actor-manager
…es/gcs-actor-manager
…es/gcs-autoscaler-manager
tohtana
pushed a commit
to tohtana/ray
that referenced
this pull request
Aug 29, 2025
…ray-project#56053) 🫡 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
tohtana
pushed a commit
to tohtana/ray
that referenced
this pull request
Aug 29, 2025
…ray-project#56053) 🫡 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
gangsf
pushed a commit
to gangsf/ray
that referenced
this pull request
Sep 2, 2025
…ray-project#56053) 🫡 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Gang Zhao <gang@gang-JQ62HD2C37.local>
sampan-s-nayak
pushed a commit
to sampan-s-nayak/ray
that referenced
this pull request
Sep 8, 2025
…ray-project#56053) 🫡 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: sampan <sampan@anyscale.com>
jugalshah291
pushed a commit
to jugalshah291/ray_fork
that referenced
this pull request
Sep 11, 2025
…ray-project#56053) 🫡 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
wyhong3103
pushed a commit
to wyhong3103/ray
that referenced
this pull request
Sep 12, 2025
…ray-project#56053) 🫡 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: yenhong.wong <yenhong.wong@grabtaxi.com>
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
…#56053) 🫡 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…ray-project#56053) 🫡 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🫡