Move gcs_callback_types.h to rpc_callback_types.h by sunsetxh · Pull Request #58596 · ray-project/ray

sunsetxh · 2025-11-13T14:41:49Z

Description

Move gcs_callback_types.h to rpc_callback_types.h

Related issues

gemini-code-assist

Code Review

This pull request refactors gcs_callback_types.h to grpc_callback_types.h, making the callback types more generic by removing the gcs namespace. The changes across the codebase correctly reflect this rename and namespace removal.

My main feedback is to update the comments within the newly renamed grpc_callback_types.h to remove specific references to "GCS", aligning them with the goal of making these types more generic. This will improve code clarity and maintainability.

sunsetxh · 2025-11-13T14:52:18Z

@tianyi-ge

edoakes · 2025-11-13T15:08:33Z

The callbacks in that file are not specific to gRPC. To avoid leaking implementation details of the rpc layer, let's call this rpc_callback_types. We could also move it to the rpc/ directory instead, might make more sense than dropping it in common/.

sunsetxh · 2025-11-13T15:11:23Z

@edoakes Thinks. I'll fix it soon.

tianyi-ge · 2025-11-13T15:31:56Z

Thanks! Could you fix this comment as well
#57004 (comment)

jjyao · 2025-11-19T15:53:04Z

I converted it to draft since it's still wip.

src/ray/raylet_rpc_client/raylet_client_with_io_context.cc

tianyi-ge · 2025-12-02T01:02:20Z

src/ray/raylet_rpc_client/raylet_client_with_io_context.h

  /// during the whole lifetime of client.
  std::unique_ptr<rpc::ClientCallManager> client_call_manager_;
  std::unique_ptr<rpc::RayletClient> raylet_client_;
+  InstrumentedIOContextWithThread io_context_;


It's different from the original design. io_context_ used to be static, so all raylet clients share one io_context_. Now each raylet client creates their own. Consider static it and initialize it only once

cursor · 2025-12-02T15:58:32Z

src/ray/raylet_rpc_client/raylet_client_with_io_context.h

  /// during the whole lifetime of client.
  std::unique_ptr<rpc::ClientCallManager> client_call_manager_;
  std::unique_ptr<rpc::RayletClient> raylet_client_;
+  inline static InstrumentedIOContextWithThread io_context_{"raylet_client_io_service"};


Bug: Static member changes io_context initialization timing

The io_context_ was changed from a function-local static to a class-level inline static member. While both create a singleton, the initialization timing differs significantly: function-local static uses lazy initialization (thread starts on first use), whereas class-level inline static uses eager initialization (thread starts during static initialization, before main()). Since InstrumentedIOContextWithThread spawns a thread in its constructor, this change causes a background thread to start before the program's main() function runs, which could cause issues with static initialization order or when the code is used from shared libraries. As noted by the reviewer, this differs from the original design intent.

Additional Locations (1)

src/ray/raylet_rpc_client/raylet_client_with_io_context.cc#L32-L33

jjyao

LG. Thanks for the contribution!

jjyao · 2025-12-02T22:47:11Z

src/ray/raylet_rpc_client/raylet_client_with_io_context.cc

  // This is to avoid creating multiple threads for multiple clients in python.
-  static InstrumentedIOContextWithThread io_context("raylet_client_io_service");
-  instrumented_io_context &io_service = io_context.GetIoService();
+  instrumented_io_context &io_service = io_context_.GetIoService();


Why changing this, seems unrelated to this PR

Ah @sunsetxh is fixing your old comments #57004 (comment)

Let's separate it out to its own PR.

sunsetxh · 2025-12-03T14:03:19Z

@jjyao How to run python test cases locally

jjyao · 2025-12-05T04:55:37Z

@sunsetxh you can cd to the test file folder and just run pytest test_xxx.py

jjyao · 2025-12-11T19:45:08Z

Test failures

jjyao · 2025-12-18T17:02:24Z

Test failures

tianyi-ge · 2025-12-24T07:35:49Z

Hi @jjyao looks like ray upgraded psutil to 7.2.0, but it does not provide psutil._common.sdiskusage directly. maybe we can create a fake object via namedtuple

python/ray/dashboard/modules/reporter/reporter_agent.py

Signed-off-by: yuchao-wang <wyc984872769@hotmail.com>

Signed-off-by: tianyi-ge <tianyig@outlook.com>

tianyi-ge · 2026-01-04T07:05:27Z

Hi @jjyao can you take a look?

jjyao · 2026-01-04T07:10:17Z

cc @edoakes for merge.

## Description Move gcs_callback_types.h to rpc_callback_types.h ## Related issues Closes ray-project#58597 --------- Signed-off-by: tianyi-ge <tianyig@outlook.com> Co-authored-by: tianyi-ge <tianyig@outlook.com> Signed-off-by: DPatel_7 <dpatel@gocommotion.com>

## Description Move gcs_callback_types.h to rpc_callback_types.h ## Related issues Closes ray-project#58597 --------- Signed-off-by: tianyi-ge <tianyig@outlook.com> Co-authored-by: tianyi-ge <tianyig@outlook.com> Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>

## Description Move gcs_callback_types.h to rpc_callback_types.h ## Related issues Closes ray-project#58597 --------- Signed-off-by: tianyi-ge <tianyig@outlook.com> Co-authored-by: tianyi-ge <tianyig@outlook.com>

sunsetxh requested a review from a team as a code owner November 13, 2025 14:41

sunsetxh force-pushed the br_grpc_callback branch from c2c9de7 to 63261b9 Compare November 13, 2025 14:43

gemini-code-assist bot reviewed Nov 13, 2025

View reviewed changes

sunsetxh changed the title ~~[wip]move gcs_callback_types.h to grpc_callback_types.h~~ [wip]rename gcs_callback_types.h to grpc_callback_types.h Nov 13, 2025

sunsetxh force-pushed the br_grpc_callback branch 2 times, most recently from 04821bd to 14586e3 Compare November 13, 2025 16:42

ray-gardener bot added core Issues that should be addressed in Ray Core community-contribution Contributed by the community labels Nov 13, 2025

sunsetxh force-pushed the br_grpc_callback branch 3 times, most recently from fbaaccc to 87d8331 Compare November 19, 2025 14:38

jjyao marked this pull request as draft November 19, 2025 15:52

sunsetxh force-pushed the br_grpc_callback branch 3 times, most recently from 7dcfe82 to f48d26d Compare November 24, 2025 14:33

sunsetxh force-pushed the br_grpc_callback branch 2 times, most recently from f0c56ca to 74af556 Compare December 1, 2025 15:33

sunsetxh changed the title ~~[wip]rename gcs_callback_types.h to grpc_callback_types.h~~ rename gcs_callback_types.h to grpc_callback_types.h Dec 1, 2025

sunsetxh marked this pull request as ready for review December 1, 2025 15:35

cursor bot reviewed Dec 1, 2025

View reviewed changes

src/ray/raylet_rpc_client/raylet_client_with_io_context.cc Outdated Show resolved Hide resolved

tianyi-ge reviewed Dec 2, 2025

View reviewed changes

sunsetxh force-pushed the br_grpc_callback branch from 74af556 to e00d99b Compare December 2, 2025 15:53

cursor bot reviewed Dec 2, 2025

View reviewed changes

jjyao changed the title ~~rename gcs_callback_types.h to grpc_callback_types.h~~ Move gcs_callback_types.h to rpc_callback_types.h Dec 2, 2025

jjyao reviewed Dec 2, 2025

View reviewed changes

sunsetxh force-pushed the br_grpc_callback branch 3 times, most recently from 1a19c01 to 81000df Compare December 11, 2025 15:44

edoakes added the go add ONLY when ready to merge, run all tests label Dec 12, 2025

sunsetxh force-pushed the br_grpc_callback branch 2 times, most recently from 4cb6167 to 34b6284 Compare December 13, 2025 09:50

codope assigned jjyao Dec 18, 2025

sunsetxh force-pushed the br_grpc_callback branch 3 times, most recently from b2707ed to 091c40c Compare December 24, 2025 05:08

sunsetxh force-pushed the br_grpc_callback branch from 091c40c to 8dd8e94 Compare December 24, 2025 07:47

cursor bot reviewed Dec 24, 2025

View reviewed changes

python/ray/dashboard/modules/reporter/reporter_agent.py Outdated Show resolved Hide resolved

sunsetxh force-pushed the br_grpc_callback branch from 8dd8e94 to 1ea8e17 Compare December 24, 2025 08:12

rename gcs_callback_types.h to grpc_callback_types.h

a38ab51

Signed-off-by: yuchao-wang <wyc984872769@hotmail.com>

sunsetxh force-pushed the br_grpc_callback branch from 1ea8e17 to a38ab51 Compare December 26, 2025 15:12

[core] revert unnecessary changes

18859d3

Signed-off-by: tianyi-ge <tianyig@outlook.com>

jjyao approved these changes Jan 4, 2026

View reviewed changes

edoakes merged commit 7cf58ef into ray-project:master Jan 5, 2026
6 checks passed

tianyi-ge mentioned this pull request Jan 5, 2026

[core] Support Viewing PIDs for Dashboard and Runtime Env Agent #58701

Merged

Conversation

sunsetxh commented Nov 13, 2025 • edited by jjyao Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

sunsetxh commented Nov 13, 2025

Uh oh!

edoakes commented Nov 13, 2025

Uh oh!

sunsetxh commented Nov 13, 2025

Uh oh!

tianyi-ge commented Nov 13, 2025

Uh oh!

jjyao commented Nov 19, 2025

Uh oh!

Uh oh!

tianyi-ge Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

cursor bot Dec 2, 2025

Choose a reason for hiding this comment

Bug: Static member changes io_context initialization timing

Uh oh!

jjyao left a comment

Choose a reason for hiding this comment

Uh oh!

jjyao Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

tianyi-ge Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

sunsetxh Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

jjyao Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

sunsetxh commented Dec 3, 2025

Uh oh!

jjyao commented Dec 5, 2025

Uh oh!

jjyao commented Dec 11, 2025

Uh oh!

jjyao commented Dec 18, 2025

Uh oh!

tianyi-ge commented Dec 24, 2025

Uh oh!

Uh oh!

tianyi-ge commented Jan 4, 2026

Uh oh!

jjyao commented Jan 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sunsetxh commented Nov 13, 2025 •

edited by jjyao

Loading