[Core] Support X-Ray-Authorization fallback header for accepting auth token in dashboard
#58819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sampan <sampan@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for a new X-Ray-Auth header to accept authentication tokens, primarily for use by KubeRay when proxying requests to the Ray dashboard. The changes are well-implemented, ensuring that the standard Authorization header takes precedence over the new X-Ray-Auth header. Comprehensive tests have been added to validate both the functionality of the new header and its precedence logic. The code is clear, follows existing patterns, and correctly addresses the stated problem. No critical, high, or medium severity issues were found.
Collaborator
|
Please note in PR description that this is only for the dashboard/API server |
edoakes
changed the title
X-Ray-Auth header for acception auth tokenX-Ray-Auth fallback header for accepting auth token in dashbaord
edoakes
changed the title
X-Ray-Auth fallback header for accepting auth token in dashbaordX-Ray-Auth fallback header for accepting auth token in dashboard
added 2 commits
November 19, 2025 16:13
Signed-off-by: sampan <sampan@anyscale.com>
Signed-off-by: sampan <sampan@anyscale.com>
sampan-s-nayak
changed the title
X-Ray-Auth fallback header for accepting auth token in dashboardX-Ray-Authorization fallback header for accepting auth token in dashboard
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
edoakes
reviewed
Nov 19, 2025
python/ray/_private/authentication/http_token_authentication.py
Outdated
Show resolved
Hide resolved
edoakes
approved these changes
Nov 19, 2025
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…th token in dashboard (ray-project#58819) support `X-Ray-Authorization` header for accepting auth token. this is used by kuberay to pass auth token when it is making requests to ray dashboard through Kubernetes API via proxy. this only affects api's using the middleware (dashboard head and runtime env agent server) --------- Signed-off-by: sampan <sampan@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: sampan <sampan@anyscale.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
edoakes
added a commit
to edoakes/ray
that referenced
this pull request
Nov 19, 2025
…th token in dashboard (ray-project#58819) support `X-Ray-Authorization` header for accepting auth token. this is used by kuberay to pass auth token when it is making requests to ray dashboard through Kubernetes API via proxy. this only affects api's using the middleware (dashboard head and runtime env agent server) --------- Signed-off-by: sampan <sampan@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: sampan <sampan@anyscale.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
aslonnie
pushed a commit
that referenced
this pull request
Nov 19, 2025
Cherry pick: #58819 Signed-off-by: sampan <sampan@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: Sampan S Nayak <sampansnayak2@gmail.com> Co-authored-by: sampan <sampan@anyscale.com>
Merged
4 tasks
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Nov 21, 2025
…th token in dashboard (ray-project#58819) support `X-Ray-Authorization` header for accepting auth token. this is used by kuberay to pass auth token when it is making requests to ray dashboard through Kubernetes API via proxy. this only affects api's using the middleware (dashboard head and runtime env agent server) --------- Signed-off-by: sampan <sampan@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: sampan <sampan@anyscale.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
ykdojo
pushed a commit
to ykdojo/ray
that referenced
this pull request
Nov 27, 2025
…th token in dashboard (ray-project#58819) support `X-Ray-Authorization` header for accepting auth token. this is used by kuberay to pass auth token when it is making requests to ray dashboard through Kubernetes API via proxy. this only affects api's using the middleware (dashboard head and runtime env agent server) --------- Signed-off-by: sampan <sampan@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: sampan <sampan@anyscale.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support
X-Ray-Authorizationheader for accepting auth token. this is used by kuberay to pass auth token when it is making requests to ray dashboard through Kubernetes API via proxy.this only affects api's using the middleware (dashboard head and runtime env agent server)