Skip to content

Make PrefixCacheAwareRouter imbalance threshold less surprising#59390

Merged
kouroshHakha merged 2 commits intoray-project:masterfrom
eicherseiji:change-imbalance-default
Jan 6, 2026
Merged

Make PrefixCacheAwareRouter imbalance threshold less surprising#59390
kouroshHakha merged 2 commits intoray-project:masterfrom
eicherseiji:change-imbalance-default

Conversation

@eicherseiji
Copy link
Contributor

@eicherseiji eicherseiji commented Dec 11, 2025

  • During testing this was a footgun that I and @nrghosh encountered independently. The configuration is good, but I think users expect the router to be purely prefix cache-based by default.

Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the imbalanced_threshold in PrefixCacheAffinityRouter to a very large value, making prefix-aware routing the default behavior, which is a sensible change. My review includes suggestions to update the corresponding documentation and test fixtures to align with this new default, ensuring consistency and correctness.

Signed-off-by: Seiji Eicher <seiji@anyscale.com>
@eicherseiji eicherseiji added the go add ONLY when ready to merge, run all tests label Dec 15, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Dec 30, 2025
@eicherseiji eicherseiji marked this pull request as ready for review January 6, 2026 22:39
@eicherseiji eicherseiji requested review from a team as code owners January 6, 2026 22:39
@kouroshHakha kouroshHakha merged commit 338ce48 into ray-project:master Jan 6, 2026
7 checks passed
AYou0207 pushed a commit to AYou0207/ray that referenced this pull request Jan 13, 2026
…prising (ray-project#59390)

Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>
lee1258561 pushed a commit to pinterest/ray that referenced this pull request Feb 3, 2026
…prising (ray-project#59390)

Signed-off-by: Seiji Eicher <seiji@anyscale.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Feb 3, 2026
…prising (ray-project#59390)

Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests stale The issue is stale. It will be closed within 7 days unless there are further conversation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants