Conversation
otherwise the wheel uploading will be failing Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie
force-pushed
the
lonnie-251218-twineup
branch
from
69b27ea to
9f14cd4
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the twine dependency from version 6.1.0 to 6.2.0 and the packaging dependency from version 24.0 to 25.0. These changes are reflected in both release/requirements_py310.in and release/requirements_py310.txt, including the corresponding SHA256 hash updates for the locked dependencies. No review comments were provided.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "PyGithub", | ||
| "requests", | ||
| "twine == 6.1.0", | ||
| "twine == 6.2.0", |
There was a problem hiding this comment.
Bug: twine version not updated in requirements_buildkite.in
The twine version was updated to 6.2.0 in setup.py, requirements_py310.in, and requirements_py310.txt, but requirements_buildkite.in still has twine == 6.1.0. The comment in setup.py at line 16 explicitly states "Keep this in sync with requirements_buildkite.in", so this creates an inconsistency that violates the documented sync requirement. This could cause different CI environments to use different twine versions.
otherwise the wheel uploading is failing with older versions. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
otherwise the wheel uploading is failing with older versions. Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>
otherwise the wheel uploading is failing with older versions. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
2 participants
otherwise the wheel uploading is failing with older versions.