[release test] remove unused ray image configs and methods#59812
[release test] remove unused ray image configs and methods#59812aslonnie merged 1 commit intoray-project:masterfrom
Conversation
not used anymore, we always use ray/ray-ml/ray-llm without any remapping now. Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request does a good job of removing unused Ray image configurations and the associated get_ray_image method. The changes are applied consistently across configuration files, loading logic, and tests, which improves code maintainability. I've added one comment suggesting a further small cleanup to make this refactoring more complete. Overall, great work on simplifying the configuration!
I am having trouble creating individual review comments. Click here to see my feedback.
release/ray_release/test.py (619-636)
With the removal of this get_ray_image method, it appears the byod_ray_ecr configuration is no longer used anywhere. This method was the sole consumer, specifically on line 634: ecr = config["byod_ray_ecr"].
To complete the cleanup, please consider also removing:
ray_ecrfromci/ray_ci/oss_config.yaml.byod_ray_ecrfromGlobalConfigand its initialization inrelease/ray_release/configs/global_config.py.- The corresponding assertion in
release/ray_release/tests/test_global_config.py.
This will ensure all related unused configurations are removed.
…ct#59812) not used anymore, we always use ray/ray-ml/ray-llm without any remapping now. Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com> Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>
…ct#59812) not used anymore, we always use ray/ray-ml/ray-llm without any remapping now. Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
…ct#59812) not used anymore, we always use ray/ray-ml/ray-llm without any remapping now. Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
2 participants
not used anymore, we always use ray/ray-ml/ray-llm without any remapping now.