Skip to content

[Data] Don't downscale actors if the operator hasn't received any inputs#59883

Merged
bveeramani merged 5 commits intomasterfrom
no-downscale-if-no-inputs
Jan 6, 2026
Merged

[Data] Don't downscale actors if the operator hasn't received any inputs#59883
bveeramani merged 5 commits intomasterfrom
no-downscale-if-no-inputs

Conversation

@bveeramani
Copy link
Member

If you have a pipeline like read --> [some cpu transformation] --> [gpu transformation init_concurrency =N] --> write, the gpu transformation might downscale to 0 actors if the CPU transformation is slow. This basically nullifies init_concurrency and can cause cold-start delays.

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani bveeramani requested a review from a team as a code owner January 6, 2026 08:04
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prevents the actor autoscaler from downscaling actors if the operator has not yet received any inputs. This is a good fix to prevent premature downscaling, especially in pipelines where an upstream operator might be slow to produce its first output. The implementation is straightforward and a corresponding test case has been added. I've found a minor issue in a test comment that should be corrected for clarity.

bveeramani and others added 3 commits January 6, 2026 00:18
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: You-Cheng Lin <106612301+owenowenisme@users.noreply.github.com>
@owenowenisme owenowenisme added the go add ONLY when ready to merge, run all tests label Jan 6, 2026
Copy link
Member

@owenowenisme owenowenisme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bveeramani bveeramani enabled auto-merge (squash) January 6, 2026 08:30
…oject/ray into no-downscale-if-no-inputs

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@github-actions github-actions bot disabled auto-merge January 6, 2026 08:38
@bveeramani bveeramani enabled auto-merge (squash) January 6, 2026 08:38
@bveeramani bveeramani merged commit 22cf6ef into master Jan 6, 2026
7 checks passed
@bveeramani bveeramani deleted the no-downscale-if-no-inputs branch January 6, 2026 09:15
AYou0207 pushed a commit to AYou0207/ray that referenced this pull request Jan 13, 2026
…uts (ray-project#59883)

If you have a pipeline like `read --> [some cpu transformation] --> [gpu
transformation init_concurrency =N] --> write`, the `gpu transformation`
might downscale to 0 actors if the CPU transformation is slow. This
basically nullifies `init_concurrency` and can cause cold-start delays.

---------

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: You-Cheng Lin <106612301+owenowenisme@users.noreply.github.com>
Co-authored-by: You-Cheng Lin <106612301+owenowenisme@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>
lee1258561 pushed a commit to pinterest/ray that referenced this pull request Feb 3, 2026
…uts (ray-project#59883)

If you have a pipeline like `read --> [some cpu transformation] --> [gpu
transformation init_concurrency =N] --> write`, the `gpu transformation`
might downscale to 0 actors if the CPU transformation is slow. This
basically nullifies `init_concurrency` and can cause cold-start delays.

---------

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: You-Cheng Lin <106612301+owenowenisme@users.noreply.github.com>
Co-authored-by: You-Cheng Lin <106612301+owenowenisme@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Feb 3, 2026
…uts (ray-project#59883)

If you have a pipeline like `read --> [some cpu transformation] --> [gpu
transformation init_concurrency =N] --> write`, the `gpu transformation`
might downscale to 0 actors if the CPU transformation is slow. This
basically nullifies `init_concurrency` and can cause cold-start delays.

---------

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: You-Cheng Lin <106612301+owenowenisme@users.noreply.github.com>
Co-authored-by: You-Cheng Lin <106612301+owenowenisme@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants