[core] Deleting a bunch of unused GCS mocks.#60015
Merged
Conversation
Signed-off-by: irabbani <israbbani@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes several GCS mock files. While removing dead code is beneficial for maintainability, I have a concern that one of the deleted mock files might still be in use by a test, which could break the build. Please see my comment for details. The other deletions appear to be straightforward cleanup.
I am having trouble creating individual review comments. Click here to see my feedback.
src/mock/ray/gcs/gcs_actor_scheduler.h (1-104)
The corresponding header src/ray/gcs/gcs_actor_scheduler.h contains a friend class GcsActorSchedulerMockTest; declaration. This test class likely uses the mocks defined in this file, such as MockGcsActorScheduler. Since the test file itself does not appear to be removed in this pull request, deleting this mock header is likely to cause a build failure.
edoakes
approved these changes
Jan 9, 2026
AYou0207
pushed a commit
to AYou0207/ray
that referenced
this pull request
Jan 13, 2026
Dead code is a maintenance burden. Removing unused mocks. This came up as I was working on removing the ClusterLeaseManager from the GCS in ray-project#60008. Signed-off-by: irabbani <israbbani@gmail.com> Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>
lee1258561
pushed a commit
to pinterest/ray
that referenced
this pull request
Feb 3, 2026
Dead code is a maintenance burden. Removing unused mocks. This came up as I was working on removing the ClusterLeaseManager from the GCS in ray-project#60008. Signed-off-by: irabbani <israbbani@gmail.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Feb 3, 2026
Dead code is a maintenance burden. Removing unused mocks. This came up as I was working on removing the ClusterLeaseManager from the GCS in ray-project#60008. Signed-off-by: irabbani <israbbani@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dead code is a maintenance burden. Removing unused mocks.
This came up as I was working on removing the ClusterLeaseManager from the GCS in #60008.