Skip to content

[core] Deleting a bunch of unused GCS mocks.#60015

Merged
edoakes merged 1 commit intomasterfrom
irabbani/gcs-mocking-cleanup-1
Jan 9, 2026
Merged

[core] Deleting a bunch of unused GCS mocks.#60015
edoakes merged 1 commit intomasterfrom
irabbani/gcs-mocking-cleanup-1

Conversation

@israbbani
Copy link
Contributor

@israbbani israbbani commented Jan 9, 2026

Dead code is a maintenance burden. Removing unused mocks.

This came up as I was working on removing the ClusterLeaseManager from the GCS in #60008.

Signed-off-by: irabbani <israbbani@gmail.com>
@israbbani israbbani added the go add ONLY when ready to merge, run all tests label Jan 9, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several GCS mock files. While removing dead code is beneficial for maintainability, I have a concern that one of the deleted mock files might still be in use by a test, which could break the build. Please see my comment for details. The other deletions appear to be straightforward cleanup.

I am having trouble creating individual review comments. Click here to see my feedback.

src/mock/ray/gcs/gcs_actor_scheduler.h (1-104)

critical

The corresponding header src/ray/gcs/gcs_actor_scheduler.h contains a friend class GcsActorSchedulerMockTest; declaration. This test class likely uses the mocks defined in this file, such as MockGcsActorScheduler. Since the test file itself does not appear to be removed in this pull request, deleting this mock header is likely to cause a build failure.

@israbbani israbbani added the core Issues that should be addressed in Ray Core label Jan 9, 2026
@israbbani israbbani marked this pull request as ready for review January 9, 2026 21:58
@israbbani israbbani requested a review from a team as a code owner January 9, 2026 21:58
@edoakes edoakes enabled auto-merge (squash) January 9, 2026 22:23
@edoakes edoakes merged commit ccda219 into master Jan 9, 2026
6 of 7 checks passed
@edoakes edoakes deleted the irabbani/gcs-mocking-cleanup-1 branch January 9, 2026 23:39
AYou0207 pushed a commit to AYou0207/ray that referenced this pull request Jan 13, 2026
Dead code is a maintenance burden. Removing unused mocks.

This came up as I was working on removing the ClusterLeaseManager from
the GCS in ray-project#60008.

Signed-off-by: irabbani <israbbani@gmail.com>
Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>
lee1258561 pushed a commit to pinterest/ray that referenced this pull request Feb 3, 2026
Dead code is a maintenance burden. Removing unused mocks. 

This came up as I was working on removing the ClusterLeaseManager from
the GCS in ray-project#60008.

Signed-off-by: irabbani <israbbani@gmail.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Feb 3, 2026
Dead code is a maintenance burden. Removing unused mocks. 

This came up as I was working on removing the ClusterLeaseManager from
the GCS in ray-project#60008.

Signed-off-by: irabbani <israbbani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants