Skip to content

[Data] Disable filter when no valid checkpoint#60095

Closed
wxwmd wants to merge 7 commits intoray-project:masterfrom
wxwmd:disable_filter_when_no_checkpoint
Closed

[Data] Disable filter when no valid checkpoint#60095
wxwmd wants to merge 7 commits intoray-project:masterfrom
wxwmd:disable_filter_when_no_checkpoint

Conversation

@wxwmd
Copy link
Copy Markdown
Contributor

@wxwmd wxwmd commented Jan 13, 2026 •
edited
Loading

I am using Raydata's Checkpoint.

When rayjob runs for the first time, checkpoint_path is an empty directory. At this point, there is no need to filter the input_block; it can be returned directly.

By doing this, when a rayjob runs for the first time(that is, without checkpoint):
image

When a rayjob runs for the second time(with checkpoint):
image

@wxwmd wxwmd requested a review from a team as a code owner January 13, 2026 07:31
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jan 13, 2026

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@wxwmd
Copy link
Copy Markdown
Contributor Author

wxwmd commented Jan 13, 2026

@owenowenisme hi, please check this when you have time

@ray-gardener ray-gardener bot added data Ray Data-related issues community-contribution Contributed by the community labels Jan 13, 2026
@owenowenisme owenowenisme self-assigned this Jan 13, 2026
do not filter input block when no checkpoint
2cd9eb6 
Signed-off-by: xiaowen.wxw <wxw403883@alibaba-inc.com>

do not filter input block when no checkpoint
Signed-off-by: xiaowen.wxw <wxw403883@alibaba-inc.com>

do not filter input block when no checkpoint
Signed-off-by: xiaowen.wxw <wxw403883@alibaba-inc.com>

do not filter input block when no checkpoint
Signed-off-by: xiaowen.wxw <wxw403883@alibaba-inc.com>
@wxwmd wxwmd force-pushed the disable_filter_when_no_checkpoint branch from 1df29e0 to 2cd9eb6 Compare January 14, 2026 02:02
cursor[bot]
cursor bot reviewed Jan 14, 2026
View reviewed changes
@wxwmd wxwmd force-pushed the disable_filter_when_no_checkpoint branch 2 times, most recently from 36b5c99 to 567dea5 Compare January 14, 2026 05:56
why ut failed
47a1cf9 
Signed-off-by: xiaowen.wxw <wxw403883@alibaba-inc.com>
@wxwmd wxwmd force-pushed the disable_filter_when_no_checkpoint branch from 567dea5 to 47a1cf9 Compare January 14, 2026 07:09
why ut failed
8c2a4b0 
Signed-off-by: xiaowen.wxw <wxw403883@alibaba-inc.com>
cursor[bot]
cursor bot reviewed Jan 14, 2026
View reviewed changes
retry ut
d363090 
Signed-off-by: xiaowen.wxw <wxw403883@alibaba-inc.com>
@wxwmd wxwmd force-pushed the disable_filter_when_no_checkpoint branch from 3266064 to d363090 Compare January 14, 2026 15:20
xiaowen.wxw added 3 commits January 14, 2026 23:55
retry ut
fd60ca5 
Signed-off-by: xiaowen.wxw <wxw403883@alibaba-inc.com>
Merge branch 'master' of https://github.com/ray-project/ray into disa…
2297e64 
…ble_filtering_when_ckpt_unavailable
retry ut
47b40ec 
Signed-off-by: xiaowen.wxw <wxw403883@alibaba-inc.com>
@wxwmd
Copy link
Copy Markdown
Contributor Author

wxwmd commented Jan 15, 2026

ready to be reviewed

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 29, 2026

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Jan 29, 2026
@wxwmd
Copy link
Copy Markdown
Contributor Author

wxwmd commented Jan 30, 2026

still ready to be reviewed. comment to remove the stale label

@github-actions github-actions bot added unstale A PR that has been marked unstale. It will not get marked stale again if this label is on it. and removed stale The issue is stale. It will be closed within 7 days unless there are further conversation labels Jan 30, 2026
my-vegetable-has-exploded
my-vegetable-has-exploded reviewed Feb 5, 2026
View reviewed changes
python/ray/data/checkpoint/checkpoint_filter.py
# [https://github.com/ray-project/ray/issues/54520]
checkpoint_ds.context.checkpoint_config = None

if checkpoint_ds.count() == 0:
Copy link
Copy Markdown
Contributor

@my-vegetable-has-exploded my-vegetable-has-exploded Feb 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: since we use Optional[ObjectRef[Block]] here, why not just use if ckpt_filter is not None to replace _checkpoint_existed ? This flag is a bit redundant.

@wxwmd
Copy link
Copy Markdown
Contributor Author

wxwmd commented Feb 24, 2026

merged into #60294

@wxwmd wxwmd closed this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

+1 more reviewer

@my-vegetable-has-exploded my-vegetable-has-exploded my-vegetable-has-exploded left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@owenowenisme owenowenisme

Labels

community-contribution Contributed by the community data Ray Data-related issues unstale A PR that has been marked unstale. It will not get marked stale again if this label is on it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wxwmd @my-vegetable-has-exploded @owenowenisme @iamjustinhsu