Skip to content

[data] Allow configuring DefaultClusterAutoscalerV2 thresholds via en…#60133

Merged
bveeramani merged 3 commits intoray-project:masterfrom
rushikeshadhav:data/default-cluster-autoscaler-v2-env-v2
Jan 19, 2026
Merged

[data] Allow configuring DefaultClusterAutoscalerV2 thresholds via en…#60133
bveeramani merged 3 commits intoray-project:masterfrom
rushikeshadhav:data/default-cluster-autoscaler-v2-env-v2

Conversation

@rushikeshadhav
Copy link
Contributor

Description

Make DefaultClusterAutoscalerV2 knobs configurable via environment variables

Related issues

Closes #60004

@rushikeshadhav rushikeshadhav requested a review from a team as a code owner January 14, 2026 06:47
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable improvement by making several key autoscaling thresholds configurable via environment variables in DefaultClusterAutoscalerV2. This enhances the flexibility and deployability of the autoscaler by allowing dynamic adjustment of its behavior without code changes. The overall approach of using env_float and env_integer functions for configuration is sound. However, a critical issue was identified regarding the availability of the env_float function.

@bveeramani
Copy link
Member

Good to merge after CI passes and import is fixed

@bveeramani
Copy link
Member

Hey @rushikeshadhav , any update on this?

@rushikeshadhav rushikeshadhav force-pushed the data/default-cluster-autoscaler-v2-env-v2 branch 2 times, most recently from 09e0028 to 51a20e0 Compare January 16, 2026 07:13
…v vars

Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com>
Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com>
@rushikeshadhav rushikeshadhav force-pushed the data/default-cluster-autoscaler-v2-env-v2 branch from 51a20e0 to 50f43f4 Compare January 16, 2026 07:14
@rushikeshadhav
Copy link
Contributor Author

Hey @rushikeshadhav , any update on this?

I have made the required changes, can you please check?

Copy link
Member

@bveeramani bveeramani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@bveeramani bveeramani enabled auto-merge (squash) January 19, 2026 08:21
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jan 19, 2026
@bveeramani bveeramani merged commit 0bf74f2 into ray-project:master Jan 19, 2026
8 checks passed
400Ping pushed a commit to 400Ping/ray that referenced this pull request Jan 19, 2026
ray-project#60133)

## Description
> Make DefaultClusterAutoscalerV2 knobs configurable via environment
variables

## Related issues
> Closes ray-project#60004

---------

Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
jinbum-kim pushed a commit to jinbum-kim/ray that referenced this pull request Jan 29, 2026
ray-project#60133)

## Description
> Make DefaultClusterAutoscalerV2 knobs configurable via environment
variables

## Related issues
> Closes ray-project#60004

---------

Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: jinbum-kim <jinbum9958@gmail.com>
zzchun pushed a commit to antgroup/ant-ray that referenced this pull request Jan 29, 2026
ray-project#60133)

## Description
> Make DefaultClusterAutoscalerV2 knobs configurable via environment
variables

## Related issues
> Closes ray-project#60004

---------

Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Feb 3, 2026
ray-project#60133)

## Description
> Make DefaultClusterAutoscalerV2 knobs configurable via environment
variables

## Related issues
> Closes ray-project#60004

---------

Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
zzchun pushed a commit to antgroup/ant-ray that referenced this pull request Feb 5, 2026
ray-project#60133)

## Description
> Make DefaultClusterAutoscalerV2 knobs configurable via environment
variables

## Related issues
> Closes ray-project#60004

---------

Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contributed by the community data Ray Data-related issues go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Data] Make DefaultClusterAutoscalerV2 knobs configurable via environment variables

2 participants