[wheel] always declare ray-cpp extra#60189
Merged
aslonnie merged 4 commits intoray-project:masterfrom Jan 17, 2026
Merged
Conversation
so that it is consistent no matter how we build the wheel. `[cpp]` and `[all-cpp]` extra's are not included in `[all]` today. so unless user explicitly specify them, they will be skipped. as a result, we do not need to drop them from the extra declarations but can just always include them. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie
added
alpha
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the setup.py script by always declaring the [cpp] and [all-cpp] extras for the ray wheel. The changes remove the conditional logic that previously disabled these extras for development builds or when C++ extensions were not being built. This makes the declared extras consistent across all build configurations, which is a good improvement for maintainability. The implementation is straightforward and correct, and I see no issues with it.
andrew-anyscale
approved these changes
Jan 16, 2026
limarkdcunha
pushed a commit
to limarkdcunha/ray
that referenced
this pull request
Jan 18, 2026
so that it is consistent no matter how we build the wheel. `[cpp]` and `[all-cpp]` extra's are not included in `[all]` today. so unless user explicitly specify them, they will be skipped. as a result, we do not need to drop them from the extra declarations but can just always include them. Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Limark Dcunha <limarkdcunha@gmail.com>
jinbum-kim
pushed a commit
to jinbum-kim/ray
that referenced
this pull request
Jan 29, 2026
so that it is consistent no matter how we build the wheel. `[cpp]` and `[all-cpp]` extra's are not included in `[all]` today. so unless user explicitly specify them, they will be skipped. as a result, we do not need to drop them from the extra declarations but can just always include them. Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: jinbum-kim <jinbum9958@gmail.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Feb 3, 2026
so that it is consistent no matter how we build the wheel. `[cpp]` and `[all-cpp]` extra's are not included in `[all]` today. so unless user explicitly specify them, they will be skipped. as a result, we do not need to drop them from the extra declarations but can just always include them. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that it is consistent no matter how we build the wheel.
[cpp]and[all-cpp]extra's are not included in[all]today. so unless user explicitly specify them, they will be skipped. as a result, we do not need to drop them from the extra declarations but can just always include them.