[RLlib] Fix/torch gpu test#60246
Merged
simonsays1980 merged 26 commits intoray-project:masterfrom Jan 23, 2026
Merged
Conversation
Signed-off-by: Ubuntu <ubuntu@ip-172-31-12-47.us-west-2.compute.internal>
Signed-off-by: Hassam Sheikh <hassamsheikh1@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-enables the test_torch_rl_module_gpu test in rllib/BUILD.bazel. However, a syntax error was introduced in the process. The size attribute for the py_test is missing a closing quote, which will cause the build to fail. This needs to be fixed.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Hassam Ullah Sheikh <hassamsheikh1@gmail.com>
Signed-off-by: Hassam Sheikh <hassamsheikh1@gmail.com>
Signed-off-by: Hassam Sheikh <hassamsheikh1@gmail.com>
rllib/BUILD.bazel
Outdated
| py_test( | ||
| name = "test_torch_rl_module_gpu", | ||
| main = "core/rl_module/torch/tests/test_torch_rl_module.py", | ||
| tags = ["team:rllib", "core", "gpu", "exclusive"], |
Contributor
There was a problem hiding this comment.
nits: by convention, we have tags in the alphabetical order and line-by-line. Check other py_tests for reference.
kamil-kaczmarek
requested changes
Jan 16, 2026
Contributor
kamil-kaczmarek
left a comment
kamil-kaczmarek
left a comment
There was a problem hiding this comment.
Small nit in comments
Signed-off-by: Hassam Sheikh <hassamsheikh1@gmail.com>
Signed-off-by: Hassam Sheikh <hassamsheikh1@gmail.com>
Signed-off-by: Hassam Sheikh <hassamsheikh1@gmail.com>
Signed-off-by: Hassam Sheikh <hassamsheikh1@gmail.com>
Contributor
|
Not sure why test were failing because not related to PR. Let's try again. |
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Jan 26, 2026
jinbum-kim
pushed a commit
to jinbum-kim/ray
that referenced
this pull request
Jan 29, 2026
Signed-off-by: jinbum-kim <jinbum9958@gmail.com>
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Feb 1, 2026
Signed-off-by: 400Ping <jiekaichang@apache.org>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uncommenting test_torch_rl_module_gpu test in BAZEL.build