[release test] remove save_metrics method in runner#60268
Merged
aslonnie merged 1 commit intoray-project:masterfrom Jan 20, 2026
Merged
[release test] remove save_metrics method in runner#60268aslonnie merged 1 commit intoray-project:masterfrom
save_metrics method in runner#60268aslonnie merged 1 commit intoray-project:masterfrom
Conversation
metrics saving is handled in job wrapper Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the metrics saving logic by removing the save_metrics method from the CommandRunner hierarchy and its call site in glue.py. The responsibility for saving metrics is now handled within the _anyscale_job_wrapper.py script, as described in the pull request. The changes are clean, consistent, and correctly remove the now-dead code. This is a good simplification of the codebase.
ray-gardener
bot
added
core
andrew-anyscale
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metrics saving is handled in job wrapper