Skip to content

feat(ci): add wandaspecs for local discovery#60718

Closed
andrew-anyscale wants to merge 1 commit intoandrew/revup/master/refac-namesfrom
andrew/revup/master/wanda-specs
Closed

feat(ci): add wandaspecs for local discovery#60718
andrew-anyscale wants to merge 1 commit intoandrew/revup/master/refac-namesfrom
andrew/revup/master/wanda-specs

Conversation

@andrew-anyscale
Copy link
Copy Markdown
Contributor

Pre-req to local wheel+image building using Wanda. This will allow spec discovery to source pre-req images for the wheel.

Topic: wanda-specs
Relative: refac-names
Signed-off-by: andrew andrew@anyscale.com

Pre-req to local wheel+image building using Wanda. This will allow spec discovery to source pre-req images for the wheel.

Topic: wanda-specs
Relative: refac-names
Signed-off-by: andrew <andrew@anyscale.com>
@andrew-anyscale
Copy link
Copy Markdown
Contributor Author

Reviews in this chain:
#60717 refactor(ci): Unique env name for images
 └#60718 feat(ci): add wandaspecs for local discovery
  └#60564 feat(build): add container-resource-utils
   └#60565 feat(build): add build-wheel.sh script for local wheel generation

@andrew-anyscale
Copy link
Copy Markdown
Contributor Author

# head base diff date summary
0 f7caebe5 c152fc48 diff Feb 3 10:24 AM 1 file changed, 10 insertions(+)

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the .wandaspecs configuration file to enable local discovery of Wanda specifications, which is a prerequisite for local wheel and image building. The file correctly points to the ci/docker/ directory where the spec files are located. The comments included in the file are clear and effectively explain its purpose and behavior in different contexts (local vs. CI). The change is straightforward and appears correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant