Skip to content

[Core] Add submission job proto changes#60857

Merged
edoakes merged 9 commits intomasterfrom
job_events_missing_fields
Mar 20, 2026
Merged

[Core] Add submission job proto changes#60857
edoakes merged 9 commits intomasterfrom
job_events_missing_fields

Conversation

@sampan-s-nayak
Copy link
Copy Markdown
Contributor

@sampan-s-nayak sampan-s-nayak commented Feb 9, 2026

introduce a new one-event event type "Submission job events"

[Core] Add submission job proto changes
445401e 
Signed-off-by: sampan <sampan@anyscale.com>
gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully introduces new protobuf definitions for 'Submission Job Events', including both definition and lifecycle events. The changes correctly integrate these new event types into the existing Ray event system by updating the BUILD.bazel file, events_base_event.proto, and the Python publisher configuration. The new proto messages are well-structured and align with the existing event patterns.

cursor[bot]
cursor bot reviewed Feb 9, 2026
View reviewed changes
sampan and others added 2 commits February 9, 2026 08:02
cursor[bot]
cursor bot reviewed Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@ray-gardener ray-gardener bot added the community-contribution Contributed by the community label Feb 9, 2026
@sampan-s-nayak sampan-s-nayak added go add ONLY when ready to merge, run all tests and removed community-contribution Contributed by the community labels Feb 17, 2026
@ray-gardener ray-gardener bot added the community-contribution Contributed by the community label Feb 17, 2026
@sampan-s-nayak sampan-s-nayak removed the community-contribution Contributed by the community label Feb 23, 2026
@ray-gardener ray-gardener bot added the community-contribution Contributed by the community label Feb 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Mar 9, 2026
@sampan-s-nayak
Copy link
Copy Markdown
Contributor Author

sampan-s-nayak commented Mar 18, 2026

not stale

@github-actions github-actions bot added unstale A PR that has been marked unstale. It will not get marked stale again if this label is on it. and removed stale The issue is stale. It will be closed within 7 days unless there are further conversation labels Mar 18, 2026
@edoakes edoakes enabled auto-merge (squash) March 18, 2026 21:55
@edoakes
Copy link
Copy Markdown
Collaborator

edoakes commented Mar 18, 2026

merge conflicts @sampan-s-nayak

@sampan-s-nayak
Merge branch 'master' into job_events_missing_fields
11d3e3f 
Signed-off-by: Sampan S Nayak <sampansnayak2@gmail.com>
@github-actions github-actions bot disabled auto-merge March 20, 2026 07:12
@sampan-s-nayak
Copy link
Copy Markdown
Contributor Author

sampan-s-nayak commented Mar 20, 2026

resolved conflicts @edoakes

@edoakes edoakes merged commit 49293da into master Mar 20, 2026
6 checks passed
@edoakes edoakes deleted the job_events_missing_fields branch March 20, 2026 19:48
pedrojeronim0 pushed a commit to pedrojeronim0/ray that referenced this pull request Mar 23, 2026
@sampan-s-nayak @pedrojeronim0
[Core] Add submission job proto changes (ray-project#60857)
f6fdf49 
introduce a new one-event event type "Submission job events"

---------

Signed-off-by: sampan <sampan@anyscale.com>
Signed-off-by: Sampan S Nayak <sampansnayak2@gmail.com>
Co-authored-by: sampan <sampan@anyscale.com>
Signed-off-by: Pedro Jeronimo <pedro.jeronimo@tecnico.ulisboa.pt>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Mar 25, 2026
@sampan-s-nayak @ryanaoleary
[Core] Add submission job proto changes (ray-project#60857)
90564e7 
introduce a new one-event event type "Submission job events"

---------

Signed-off-by: sampan <sampan@anyscale.com>
Signed-off-by: Sampan S Nayak <sampansnayak2@gmail.com>
Co-authored-by: sampan <sampan@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@edoakes edoakes edoakes approved these changes

@jjyao jjyao Awaiting requested review from jjyao

@israbbani israbbani Awaiting requested review from israbbani

@MengjinYan MengjinYan Awaiting requested review from MengjinYan MengjinYan is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

community-contribution Contributed by the community go add ONLY when ready to merge, run all tests unstale A PR that has been marked unstale. It will not get marked stale again if this label is on it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sampan-s-nayak @edoakes