Skip to content

[ci] add CLI for local Docker image builder (build_image.py)#61338

Merged
aslonnie merged 1 commit intomasterfrom
andrew/revup/master/build-image-cli
Mar 4, 2026
Merged

[ci] add CLI for local Docker image builder (build_image.py)#61338
aslonnie merged 1 commit intomasterfrom
andrew/revup/master/build-image-cli

Conversation

@andrew-anyscale
Copy link
Copy Markdown
Contributor

@andrew-anyscale andrew-anyscale commented Feb 26, 2026 •
edited
Loading

Add argparse CLI with image type/platform tables, nightly alias quick-reference, and example commands. Supports --list-platforms and sensible defaults per image type.

Topic: build-image-cli
Relative: build-image-builder
Signed-off-by: andrew andrew@anyscale.com

@andrew-anyscale
Copy link
Copy Markdown
Contributor Author

andrew-anyscale commented Feb 26, 2026 •
edited
Loading

Reviews in this chain:
└#61338 [ci] add CLI for local Docker image builder (build_image.py)
　└#61042 [build] feat: add top-level build-image.sh

@andrew-anyscale andrew-anyscale mentioned this pull request Feb 26, 2026
Merged
@andrew-anyscale
Copy link
Copy Markdown
Contributor Author

andrew-anyscale commented Feb 26, 2026 •
edited
Loading

# head base diff date summary
0 084fdf79 3b7d6b47 diff Feb 25 17:43 PM 2 files changed, 223 insertions(+)
1 18f04826 2e899aee diff Feb 25 17:45 PM 0 files changed
2 030abaff b3feb416 diff Feb 25 18:40 PM 1 file changed, 3 insertions(+), 2 deletions(-)
3 acfab2c7 a0589243 rebase Feb 25 18:57 PM 0 files changed
4 f77f128e decb7686 rebase Feb 25 19:36 PM 0 files changed
5 5a12479d 7b7dbfef rebase Feb 25 20:36 PM 0 files changed
6 6e77ce0b 4bf968eb rebase Feb 25 20:38 PM 0 files changed
7 a630159e 17a2265e rebase Feb 25 20:42 PM 0 files changed
8 50c2f56c 4c6496b7 rebase Feb 25 20:53 PM 0 files changed
9 a6b29544 73b08876 rebase Feb 25 20:56 PM 0 files changed
10 9e8f8390 65d19359 rebase Feb 26 6:40 AM 0 files changed
11 73c7c3b0 8dce0127 rebase Feb 26 7:27 AM 0 files changed
12 77f9a737 fcabb707 rebase Feb 26 8:15 AM 0 files changed
13 d73eac18 ae42ac39 rebase Feb 26 8:20 AM 0 files changed
14 c83d79c3 7e545e83 rebase Feb 26 10:48 AM 0 files changed
15 dcbda350 777af75e rebase Mar 2 7:17 AM 0 files changed
16 0254cb88 d4b4392c rebase Mar 3 7:29 AM 0 files changed
17 ca00c9a7 cd973c00 rebase Mar 3 7:33 AM 0 files changed
18 adbbf88b 706e94d3 rebase Mar 3 7:37 AM 0 files changed
19 f0a7c306 706e94d3 diff Mar 3 7:40 AM 1 file changed, 5 deletions(-)
20 cc0b1022 ae486d4b rebase Mar 3 11:46 AM 0 files changed
21 ba0be702 a78f117c rebase Mar 3 12:01 PM 0 files changed
22 d8861c5d 91a43883 diff Mar 3 16:52 PM 0 files changed

@andrew-anyscale andrew-anyscale mentioned this pull request Feb 26, 2026
Merged
This was referenced Feb 26, 2026
Merged
Merged
Merged
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-builder branch from 3b7d6b4 to 2e899ae Compare February 26, 2026 01:45
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-cli branch from 084fdf7 to 18f0482 Compare February 26, 2026 01:45
@andrew-anyscale andrew-anyscale marked this pull request as ready for review February 26, 2026 01:45
gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a command-line interface to the build_image.py script, which is a great improvement for usability. The implementation uses argparse and provides helpful tables and examples in the help output. The code is well-structured and includes a new test case for the help output. I've found one area for improvement regarding hardcoded values in the example generation logic to make it more robust.

Comment thread ci/build/build_image.py
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-builder branch from 2e899ae to b3feb41 Compare February 26, 2026 02:40
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-cli branch from 18f0482 to 030abaf Compare February 26, 2026 02:40
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-builder branch from b3feb41 to a058924 Compare February 26, 2026 02:57
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-cli branch from 030abaf to acfab2c Compare February 26, 2026 02:57
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-builder branch from a058924 to decb768 Compare February 26, 2026 03:36
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-cli branch from acfab2c to f77f128 Compare February 26, 2026 03:36
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-cli branch from f77f128 to 5a12479 Compare February 26, 2026 04:36
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-builder branch from decb768 to 7b7dbfe Compare February 26, 2026 04:36
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-cli branch from 5a12479 to 6e77ce0 Compare February 26, 2026 04:38
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-builder branch from 7b7dbfe to 4bf968e Compare February 26, 2026 04:38
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-cli branch from 6e77ce0 to a630159 Compare February 26, 2026 04:42
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-builder branch 2 times, most recently from 17a2265 to 4c6496b Compare February 26, 2026 04:54
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-cli branch from a630159 to 50c2f56 Compare February 26, 2026 04:54
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-builder branch from 4c6496b to 73b0887 Compare February 26, 2026 04:56
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-cli branch from 50c2f56 to a6b2954 Compare February 26, 2026 04:56
@ray-gardener ray-gardener bot added the community-contribution Contributed by the community label Feb 26, 2026
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-builder branch from ae42ac3 to 7e545e8 Compare February 26, 2026 18:48
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-cli branch from c83d79c to dcbda35 Compare March 2, 2026 15:17
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-builder branch from 7e545e8 to 777af75 Compare March 2, 2026 15:17
@andrew-anyscale andrew-anyscale added the go add ONLY when ready to merge, run all tests label Mar 2, 2026
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-builder branch from 777af75 to d4b4392 Compare March 3, 2026 15:29
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-cli branch from dcbda35 to 0254cb8 Compare March 3, 2026 15:29
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-builder branch from d4b4392 to cd973c0 Compare March 3, 2026 15:33
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-cli branch from 0254cb8 to ca00c9a Compare March 3, 2026 15:33
@andrew-anyscale andrew-anyscale mentioned this pull request Mar 3, 2026
Merged
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-builder branch from cd973c0 to 706e94d Compare March 3, 2026 15:37
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-cli branch 3 times, most recently from f0a7c30 to cc0b102 Compare March 3, 2026 19:46
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-builder branch from d994de6 to ae486d4 Compare March 3, 2026 19:46
@aslonnie aslonnie self-requested a review March 3, 2026 19:49
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-cli branch from cc0b102 to ba0be70 Compare March 3, 2026 20:01
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-builder branch from ae486d4 to a78f117 Compare March 3, 2026 20:01
Base automatically changed from andrew/revup/master/build-image-builder to master March 3, 2026 22:52
@aslonnie
Copy link
Copy Markdown
Collaborator

aslonnie commented Mar 3, 2026

hmm.. has some conflicts?

aslonnie
aslonnie reviewed Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for conflict resolving.

@andrew-anyscale
[ci] add CLI for local Docker image builder (build_image.py)
d8861c5 
Add argparse CLI with image type/platform tables, nightly alias quick-reference, and example commands. Supports --list-platforms and sensible defaults per image type.

Topic: build-image-cli
Relative: build-image-builder
Signed-off-by: andrew <andrew@anyscale.com>
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/build-image-cli branch from ba0be70 to d8861c5 Compare March 4, 2026 00:52
@andrew-anyscale andrew-anyscale requested a review from aslonnie March 4, 2026 00:52
@andrew-anyscale
Copy link
Copy Markdown
Contributor Author

andrew-anyscale commented Mar 4, 2026

Rebase conflicts resolved 🫡

@aslonnie aslonnie enabled auto-merge (squash) March 4, 2026 01:06
@aslonnie aslonnie merged commit 5246ccc into master Mar 4, 2026
7 checks passed
@aslonnie aslonnie deleted the andrew/revup/master/build-image-cli branch March 4, 2026 02:07
bittoby pushed a commit to bittoby/ray that referenced this pull request Mar 6, 2026
@andrew-anyscale @bittoby
[ci] add CLI for local Docker image builder (build_image.py) (ray-pro…
b034018 
…ject#61338)

Add argparse CLI with image type/platform tables, nightly alias
quick-reference, and example commands. Supports --list-platforms and
sensible defaults per image type.

Signed-off-by: andrew <andrew@anyscale.com>
Signed-off-by: bittoby <bittoby@users.noreply.github.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Mar 13, 2026
@andrew-anyscale @ryanaoleary
[ci] add CLI for local Docker image builder (build_image.py) (ray-pro…
2555361 
…ject#61338)

Add argparse CLI with image type/platform tables, nightly alias
quick-reference, and example commands. Supports --list-platforms and
sensible defaults per image type.

Signed-off-by: andrew <andrew@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aslonnie aslonnie Awaiting requested review from aslonnie

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci community-contribution Contributed by the community go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrew-anyscale @aslonnie