Revert "[core] upgrade grpc to 1.58.0 to fix getenv races"#61449
Merged
Revert "[core] upgrade grpc to 1.58.0 to fix getenv races"#61449
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request reverts the gRPC upgrade from v1.58.0 back to v1.57.1, along with the corresponding boringssl dependency, to address issues with cpp ubsan tests. The changes correctly revert the dependency versions. I have one suggestion to improve the readability of a comment in the Bazel configuration.
65718f2 to
64bc787
Compare
This reverts commit d85ed28. Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com>
64bc787 to
f59d468
Compare
israbbani
approved these changes
Mar 3, 2026
rueian
added a commit
to rueian/ray
that referenced
this pull request
Mar 4, 2026
…ect#61449) This reverts commit 544a40f. Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
rueian
added a commit
to rueian/ray
that referenced
this pull request
Mar 4, 2026
…ect#61449) This reverts commit 544a40f. Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
ayushk7102
pushed a commit
to ayushk7102/ray
that referenced
this pull request
Mar 6, 2026
…ct#61449) Reverts ray-project#61195 to check if cpp ubsan tests pass in postmerge Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com> Signed-off-by: Ayush Kumar <ayushk7102@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #61195 to check if cpp ubsan tests pass in postmerge