Skip to content

Revert "[core] upgrade grpc to 1.58.0 to fix getenv races"#61449

Merged
israbbani merged 1 commit intomasterfrom
revert-61195-grpc1580
Mar 3, 2026
Merged

Revert "[core] upgrade grpc to 1.58.0 to fix getenv races"#61449
israbbani merged 1 commit intomasterfrom
revert-61195-grpc1580

Conversation

@codope
Copy link
Contributor

@codope codope commented Mar 3, 2026

Reverts #61195 to check if cpp ubsan tests pass in postmerge

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the gRPC upgrade from v1.58.0 back to v1.57.1, along with the corresponding boringssl dependency, to address issues with cpp ubsan tests. The changes correctly revert the dependency versions. I have one suggestion to improve the readability of a comment in the Bazel configuration.

@codope codope force-pushed the revert-61195-grpc1580 branch from 65718f2 to 64bc787 Compare March 3, 2026 14:38
This reverts commit d85ed28.

Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com>
@codope codope force-pushed the revert-61195-grpc1580 branch from 64bc787 to f59d468 Compare March 3, 2026 14:40
@israbbani israbbani enabled auto-merge (squash) March 3, 2026 17:30
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Mar 3, 2026
@israbbani israbbani disabled auto-merge March 3, 2026 18:12
@israbbani israbbani enabled auto-merge (squash) March 3, 2026 18:12
@ray-gardener ray-gardener bot added the core Issues that should be addressed in Ray Core label Mar 3, 2026
@israbbani israbbani merged commit 544a40f into master Mar 3, 2026
8 of 10 checks passed
@israbbani israbbani deleted the revert-61195-grpc1580 branch March 3, 2026 20:32
rueian added a commit to rueian/ray that referenced this pull request Mar 4, 2026
…ect#61449)

This reverts commit 544a40f.

Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
rueian added a commit to rueian/ray that referenced this pull request Mar 4, 2026
…ect#61449)

This reverts commit 544a40f.

Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
ayushk7102 pushed a commit to ayushk7102/ray that referenced this pull request Mar 6, 2026
…ct#61449)

Reverts ray-project#61195 to check if cpp ubsan tests pass in
postmerge

Signed-off-by: Sagar Sumit <sagarsumit09@gmail.com>
Signed-off-by: Ayush Kumar <ayushk7102@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants