[docs] using ray-project pandas mirror for doc builds#61730
Merged
Conversation
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Sphinx configuration to use a mirrored objects.inv file for the pandas library documentation, which is a good practice for ensuring build stability. My review includes a suggestion to improve maintainability by refactoring the hardcoded mirror version into a constant, as this version is shared with the scipy configuration.
Comment on lines
+837
to
+840
| "pandas": ( | ||
| "https://pandas.pydata.org/pandas-docs/stable/", | ||
| "https://github.com/ray-project/pandas/releases/download/object-mirror-0.1.0/objects.inv", | ||
| ), |
Contributor
There was a problem hiding this comment.
For better maintainability, consider defining the version string object-mirror-0.1.0 as a constant. This version is also used for the scipy intersphinx mapping. By using a constant, you can ensure that both mappings are updated consistently in the future.
For example:
_OBJECT_MIRROR_VERSION = "object-mirror-0.1.0"
intersphinx_mapping = {
# ...
"pandas": (
"https://pandas.pydata.org/pandas-docs/stable/",
f"https://github.com/ray-project/pandas/releases/download/{_OBJECT_MIRROR_VERSION}/objects.inv",
),
# ...
"scipy": (
"https://docs.scipy.org/doc/scipy/",
f"https://github.com/ray-project/scipy/releases/download/{_OBJECT_MIRROR_VERSION}/objects.inv",
),
# ...
}
goutamvenkat-anyscale
approved these changes
Mar 13, 2026
ray-gardener
bot
added
docs
abrarsheikh
pushed a commit
that referenced
this pull request
Mar 17, 2026
creating object mirror for pandas for ray doc builds cloned pandas repo and added objects.inv as an artifact Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com> Signed-off-by: abrar <abrar@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
creating object mirror for pandas for ray doc builds
cloned pandas repo and added objects.inv as an artifact