[serve] Refactor internal autoscaling policy state extraction logic into a single helper#62452
Merged
abrarsheikh merged 2 commits intoray-project:masterfrom Apr 17, 2026
Conversation
Signed-off-by: Vaishnavi Panchavati <vaishdho10@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the autoscaling policy by extracting internal state extraction logic into a new helper function, _extract_internal_policy_state. This helper is then utilized in _apply_default_params_and_merge_state and _merge_user_state_with_internal_state to reduce code duplication. I have no feedback to provide.
ray-gardener
bot
added
serve
abrarsheikh
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors duplicated internal policy state extraction (delay counter and timestamp keys) into
_extract_internal_policy_statein autoscaling_policy.py. Follow up to #58857.Related Issues