[core] Deflake node manager test#62673
Merged
dayshah merged 1 commit intoray-project:masterfrom Apr 16, 2026
Merged
Conversation
Signed-off-by: Joshua Lee <joshlee@anyscale.com>
Kunchd
approved these changes
Apr 16, 2026
Contributor
Kunchd
left a comment
Kunchd
left a comment
There was a problem hiding this comment.
Glad we're getting rid of nullptrs. It's the million dollar problem!
Contributor
Author
|
Unblocked sanitizer tests on premerge so on pass should be good to go |
Contributor
Author
actually true :kek |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the visibility of the noop_cgroup_manager library to public and integrates it into the NodeManagerTest. It adds the required Bazel dependency and replaces a null pointer with a NoopCgroupManager instance in the test suite. I have no feedback to provide as there were no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #62168 we modified the memory monitor constructor to take in a cgroup_manager which for tests is effectively passing a nullptr where we're expecting a const ref: https://github.com/ray-project/ray/pull/62168/changes#diff-d2f22b8f1bf5f9be47dacae8b467a72ee94629df12ffcc18b13447192ff3dbcfL246
Since it's not actually used in the node_manager_test I'm assuming that's how it passed CI, but it's getting flagged (rightfully) by the UBSAN test. Passing a noop cgroup manager instead.