Skip to content

[release] Declare forge as an explicit depends_on for publish steps#62687

Merged
aslonnie merged 1 commit intomasterfrom
andrew/revup/master/release-publish-forge-deps
Apr 16, 2026
Merged

[release] Declare forge as an explicit depends_on for publish steps#62687
aslonnie merged 1 commit intomasterfrom
andrew/revup/master/release-publish-forge-deps

Conversation

@andrew-anyscale
Copy link
Copy Markdown
Contributor

The four :crane: publish: steps in build.rayci.yml run inside the forge docker image (via the default docker plugin), but the dependency on the forge wanda step was implicit — not declared via depends_on. In the default unpruned pipeline this works because rayci includes every step regardless, but under RAYCI_SELECT pruning (where only the selected step and its transitive upstream deps are emitted), the forge step gets filtered out and the publish step crashes with "manifest for citemp:{build_id}-forge not found".

Making the dep explicit lets rayci's upstream dep walker include forge in the pruned pipeline whenever any publish step is selected.

Topic: release-publish-forge-deps
Signed-off-by: andrew andrew@anyscale.com

The four :crane: publish: steps in build.rayci.yml run inside the forge docker image (via the default docker plugin), but the dependency on the forge wanda step was implicit — not declared via depends_on. In the default unpruned pipeline this works because rayci includes every step regardless, but under RAYCI_SELECT pruning (where only the selected step and its transitive upstream deps are emitted), the forge step gets filtered out and the publish step crashes with "manifest for citemp:{build_id}-forge not found".

Making the dep explicit lets rayci's upstream dep walker include forge in the pruned pipeline whenever any publish step is selected.

Topic: release-publish-forge-deps
Signed-off-by: andrew <andrew@anyscale.com>
@andrew-anyscale
Copy link
Copy Markdown
Contributor Author

Reviews in this chain:
#62687 [release] Declare forge as an explicit depends_on for publish steps
 └#62685 [release] Emit RAYCI_SELECT of base-image publish keys from release-test init
  └#62686 [release] Narrow *testdeps array deps to matching variant

@andrew-anyscale
Copy link
Copy Markdown
Contributor Author

# head base diff date summary
0 da77ea3b 4c9a9d87 diff Apr 16 15:57 PM 1 file changed, 4 insertions(+)

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Buildkite release configuration in .buildkite/release/build.rayci.yml by adding a dependency on the forge step for several image build and upload tasks, including CPU, CUDA, LLM, and ML variants. I have no feedback to provide as there are no review comments.

@aslonnie aslonnie enabled auto-merge (squash) April 16, 2026 23:02
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Apr 16, 2026
@aslonnie aslonnie merged commit d8c86ea into master Apr 16, 2026
7 of 8 checks passed
@aslonnie aslonnie deleted the andrew/revup/master/release-publish-forge-deps branch April 16, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants