Skip to content

[release test] move release_tests.json upload into custom_image_build_and_test_init#62737

Merged
aslonnie merged 4 commits intomasterfrom
andrew/revup/master/upload-chunks-from-python
Apr 22, 2026
Merged

[release test] move release_tests.json upload into custom_image_build_and_test_init#62737
aslonnie merged 4 commits intomasterfrom
andrew/revup/master/upload-chunks-from-python

Conversation

@andrew-anyscale
Copy link
Copy Markdown
Contributor

@andrew-anyscale andrew-anyscale commented Apr 17, 2026

Follow-up to the chunked release_tests.json upload: have custom_image_build_and_test_init itself call buildkite-agent pipeline upload for each chunk it writes, gated behind a new --upload-to-buildkite flag. The bash init script drops its while loop and just passes the flag through.

Topic: upload-chunks-from-python
Signed-off-by: andrew andrew@anyscale.com

@andrew-anyscale andrew-anyscale requested a review from a team as a code owner April 17, 2026 21:40
@andrew-anyscale
Copy link
Copy Markdown
Contributor Author

andrew-anyscale commented Apr 17, 2026

Reviews in this chain:
#62737 [release test] move release_tests.json upload into custom_image_build_and_test_init

@andrew-anyscale
Copy link
Copy Markdown
Contributor Author

andrew-anyscale commented Apr 17, 2026

# head base diff date summary
0 14b38dfc 4b679292 diff Apr 17 14:40 PM 3 files changed, 74 insertions(+), 14 deletions(-)
1 3f5dda34 15f109b5 diff Apr 17 15:11 PM 2 files changed, 16 insertions(+)
2 1ee32b93 743d06d5 diff Apr 17 17:12 PM 0 files changed
3 238660a7 743d06d5 diff Apr 17 17:13 PM 1 file changed, 1 insertion(+), 1 deletion(-)
4 a83341d5 c33b6074 diff Apr 20 7:55 AM 1 file changed, 7 insertions(+)
5 46294fdb 30482d19 diff Apr 21 8:47 AM 0 files changed

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Buildkite pipeline upload process by moving the logic from a shell script into the Python initialization script. It introduces a new --upload-to-buildkite flag in custom_image_build_and_test_init.py, which uses the subprocess module to upload chunked test job files directly. Additionally, a new test case has been added to verify that the upload command is correctly invoked when the flag is enabled. I have no feedback to provide.

@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/chunk-release-test-uploads branch from 4b67929 to 15f109b Compare April 17, 2026 22:11
@andrew-anyscale andrew-anyscale marked this pull request as ready for review April 17, 2026 22:11
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/upload-chunks-from-python branch from 14b38df to 3f5dda3 Compare April 17, 2026 22:11
Base automatically changed from andrew/revup/master/chunk-release-test-uploads to master April 17, 2026 22:37
Copy link
Copy Markdown
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflict?

@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/upload-chunks-from-python branch 2 times, most recently from 1ee32b9 to 238660a Compare April 18, 2026 00:13
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/upload-chunks-from-python branch from 238660a to a83341d Compare April 20, 2026 14:55
@andrew-anyscale andrew-anyscale added the go add ONLY when ready to merge, run all tests label Apr 21, 2026
…_and_test_init

Follow-up to the chunked release_tests.json upload: have custom_image_build_and_test_init itself call `buildkite-agent pipeline upload` for each chunk it writes, gated behind a new --upload-to-buildkite flag. The bash init script drops its while loop and just passes the flag through.

Topic: upload-chunks-from-python
Signed-off-by: andrew <andrew@anyscale.com>
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/upload-chunks-from-python branch from a83341d to 46294fd Compare April 21, 2026 15:47
@aslonnie aslonnie enabled auto-merge (squash) April 22, 2026 01:50
@aslonnie aslonnie self-requested a review April 22, 2026 01:51
@github-actions github-actions Bot disabled auto-merge April 22, 2026 02:34
@aslonnie aslonnie enabled auto-merge (squash) April 22, 2026 18:05
@github-actions github-actions Bot disabled auto-merge April 22, 2026 18:05
@aslonnie aslonnie merged commit 622f071 into master Apr 22, 2026
7 checks passed
@aslonnie aslonnie deleted the andrew/revup/master/upload-chunks-from-python branch April 22, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devprod go add ONLY when ready to merge, run all tests release-test release test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants