Conversation
Contributor
Author
|
Reviews in this chain: |
Contributor
Author
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Buildkite pipeline upload process by moving the logic from a shell script into the Python initialization script. It introduces a new --upload-to-buildkite flag in custom_image_build_and_test_init.py, which uses the subprocess module to upload chunked test job files directly. Additionally, a new test case has been added to verify that the upload command is correctly invoked when the flag is enabled. I have no feedback to provide.
4b67929 to
15f109b
Compare
14b38df to
3f5dda3
Compare
Base automatically changed from
andrew/revup/master/chunk-release-test-uploads
to
master
April 17, 2026 22:37
1ee32b9 to
238660a
Compare
238660a to
a83341d
Compare
…_and_test_init Follow-up to the chunked release_tests.json upload: have custom_image_build_and_test_init itself call `buildkite-agent pipeline upload` for each chunk it writes, gated behind a new --upload-to-buildkite flag. The bash init script drops its while loop and just passes the flag through. Topic: upload-chunks-from-python Signed-off-by: andrew <andrew@anyscale.com>
a83341d to
46294fd
Compare
aslonnie
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the chunked release_tests.json upload: have custom_image_build_and_test_init itself call
buildkite-agent pipeline uploadfor each chunk it writes, gated behind a new --upload-to-buildkite flag. The bash init script drops its while loop and just passes the flag through.Topic: upload-chunks-from-python
Signed-off-by: andrew andrew@anyscale.com