Skip to content

[ci] Add generic extract_wanda_artifact tool#62769

Merged
aslonnie merged 1 commit intomasterfrom
andrew/revup/master/generic-extract
Apr 21, 2026
Merged

[ci] Add generic extract_wanda_artifact tool#62769
aslonnie merged 1 commit intomasterfrom
andrew/revup/master/generic-extract

Conversation

@andrew-anyscale
Copy link
Copy Markdown
Contributor

@andrew-anyscale andrew-anyscale commented Apr 20, 2026

Click CLI that extracts files matching a glob from a Wanda-cached image via crane export. Requires --wanda-image-name and --file-glob (e.g. '.whl', '.tgz'); takes --output-dir (default '.'). Errors on zero matches and on duplicate basenames across nested paths.

Topic: generic-extract
Signed-off-by: andrew andrew@anyscale.com

@andrew-anyscale
Copy link
Copy Markdown
Contributor Author

Reviews in this chain:
#62769 [ci] Add generic extract_wanda_artifact tool
 └#62770 [ci] Replace extract_wanda_wheels with extract_wanda_artifact

@andrew-anyscale
Copy link
Copy Markdown
Contributor Author

andrew-anyscale commented Apr 20, 2026

# head base diff date summary
0 d18377b5 7ea5a1aa diff Apr 20 8:07 AM 3 files changed, 283 insertions(+)
1 080da5aa c33b6074 diff Apr 20 8:26 AM 2 files changed, 16 insertions(+), 2 deletions(-)
2 3015a1d2 c33b6074 diff Apr 20 8:43 AM 3 files changed, 37 insertions(+), 9 deletions(-)
3 952e5eda c33b6074 diff Apr 20 10:24 AM 4 files changed, 53 insertions(+), 49 deletions(-)

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the extract_wanda_artifact.py script and associated tests to extract files from Wanda-cached Docker images. Feedback suggests enhancing the script by using click.Path for directory validation, adding error handling for image exports, and refining glob matching to exclude directories, thereby preventing potential runtime errors.

Comment thread ci/ray_ci/automation/extract_wanda_artifact.py Outdated
Comment thread ci/ray_ci/automation/extract_wanda_artifact.py
Comment thread ci/ray_ci/automation/extract_wanda_artifact.py Outdated
Comment thread ci/ray_ci/automation/extract_wanda_artifact.py Outdated
Comment thread ci/ray_ci/automation/extract_wanda_artifact.py Outdated
Click CLI that extracts files matching a glob from a Wanda-cached image via crane export. Requires --wanda-image-name and --file-glob (e.g. '*.whl', '*.tgz'); takes --output-dir (default '.'). Errors on zero matches and on duplicate basenames across nested paths.

Topic: generic-extract
Signed-off-by: andrew <andrew@anyscale.com>
@andrew-anyscale andrew-anyscale marked this pull request as ready for review April 20, 2026 15:26
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/generic-extract branch from d18377b to 080da5a Compare April 20, 2026 15:26
@andrew-anyscale andrew-anyscale requested a review from a team as a code owner April 20, 2026 15:26
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 080da5a. Configure here.

Comment thread ci/ray_ci/automation/extract_wanda_artifact.py
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/generic-extract branch from 080da5a to 3015a1d Compare April 20, 2026 15:43
@aslonnie aslonnie enabled auto-merge (squash) April 20, 2026 16:40
@aslonnie aslonnie self-requested a review April 20, 2026 16:40
@github-actions github-actions Bot disabled auto-merge April 20, 2026 16:40
@github-actions github-actions Bot added the go add ONLY when ready to merge, run all tests label Apr 20, 2026
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/generic-extract branch from dba91b6 to 952e5ed Compare April 20, 2026 17:24
@ray-gardener ray-gardener Bot added the devprod label Apr 20, 2026
@aslonnie aslonnie merged commit 5de85a6 into master Apr 21, 2026
8 checks passed
@aslonnie aslonnie deleted the andrew/revup/master/generic-extract branch April 21, 2026 16:19
HLDKNotFound pushed a commit to chichic21039/ray that referenced this pull request Apr 22, 2026
Click CLI that extracts files matching a glob from a Wanda-cached image
via crane export. Requires --wanda-image-name and --file-glob (e.g.
'*.whl', '*.tgz'); takes --output-dir (default '.'). Errors on zero
matches and on duplicate basenames across nested paths.

Signed-off-by: andrew <andrew@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci devprod go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants