[Data] Separate test_auto_batch_size.py with integration and unit tests#62874
Merged
bveeramani merged 2 commits intoray-project:masterfrom Apr 24, 2026
Merged
[Data] Separate test_auto_batch_size.py with integration and unit tests#62874bveeramani merged 2 commits intoray-project:masterfrom
bveeramani merged 2 commits intoray-project:masterfrom
Conversation
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
Hyunoh-Yeo
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reorganizes the test suite by moving unit tests for auto_batch_size from python/ray/data/tests/test_auto_batch_size.py to a new dedicated unit test file at python/ray/data/tests/unit/test_auto_batch_size.py. I have no feedback to provide as there are no review comments and the changes are straightforward test relocations.
Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com>
ray-gardener
Bot
added
data
owenowenisme
approved these changes
Apr 24, 2026
pushpavanthar
pushed a commit
to pushpavanthar/ray
that referenced
this pull request
Apr 25, 2026
…ts (ray-project#62874) ## Description Splits `test_auto_batch_size.py` into unit and integration test files following the `tests/unit/` convention. Moved to `tests/unit/` (5 tests): * `test_compute_auto_batch_size_basic` * `test_compute_auto_batch_size_clamped_to_one` * `test_compute_auto_batch_size_returns_none` (parametrized: `empty_iterator`, `zero_rows`) * `test_compute_auto_batch_size_iterator_includes_peeked_block` * `test_auto_batches_respect_target_size` Remain in integration file (1 test): * `test_map_batches_auto_correctness` (uses `ray_start_regular_shared`, `ray.data`) ## Related issues Related to ray-project#61125 ## Additional information Tests were classified by whether they use `ray_start_*` fixtures or make runtime `ray.*` calls — not by import paths, since the unit tests still import from `ray.data._internal.*` to exercise internal classes directly. --------- Signed-off-by: Hyunoh-Yeo <hyunoh.yeo@gmail.com> Signed-off-by: Purushotham Pushpavanth <pushpavanthar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Splits
test_auto_batch_size.pyinto unit and integration test files following thetests/unit/convention.Moved to
tests/unit/(5 tests):test_compute_auto_batch_size_basictest_compute_auto_batch_size_clamped_to_onetest_compute_auto_batch_size_returns_none(parametrized:empty_iterator,zero_rows)test_compute_auto_batch_size_iterator_includes_peeked_blocktest_auto_batches_respect_target_sizeRemain in integration file (1 test):
test_map_batches_auto_correctness(usesray_start_regular_shared,ray.data)Related issues
Related to #61125
Additional information
Tests were classified by whether they use
ray_start_*fixtures or make runtimeray.*calls — not by import paths, since the unit tests still import fromray.data._internal.*to exercise internal classes directly.