[Data] Separate test_limit_operator.py with integration and unit tests#62882
Merged
bveeramani merged 4 commits intoray-project:masterfrom Apr 24, 2026
Merged
[Data] Separate test_limit_operator.py with integration and unit tests#62882bveeramani merged 4 commits intoray-project:masterfrom
bveeramani merged 4 commits intoray-project:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reorganizes the LimitOperator tests by moving the test_per_block_limit_fn function to a new dedicated unit test file and adding the ray_start_regular_shared fixture to test_limit_estimated_num_output_bundles to ensure a Ray cluster is available for integration testing. I have no feedback to provide.
ray-gardener
Bot
added
data
owenowenisme
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Splits
test_limit_operator.pyinto unit and integration test files.test_per_block_limit_fnRemain in integration file (3 tests):
test_limit_operator(usesray_start_regular_shared)test_limit_operator_memory_leak_fix(usesray_start_regular_shared,ray.data.read_parquet,StreamingExecutor,ray.get)test_limit_estimated_num_output_bundles(usesray_start_regular_shared—make_ref_bundlesinternally callsray.put)test_per_block_limit_fnexercises_per_block_limit_fndirectly with hand-constructed pandas DataFrames and aTaskContext— no Ray cluster involved. Imports in both files were trimmed to only what each file actually uses.Related issues
Related to #61125