Skip to content

[Train / Doc] Uncomment Result.from_path in docs#62887

Merged
justinvyu merged 2 commits intoray-project:masterfrom
pseudo-rnd-thoughts:uncomment-result-rst
Apr 24, 2026
Merged

[Train / Doc] Uncomment Result.from_path in docs#62887
justinvyu merged 2 commits intoray-project:masterfrom
pseudo-rnd-thoughts:uncomment-result-rst

Conversation

@pseudo-rnd-thoughts
Copy link
Copy Markdown
Member

Description

This PR uncomment documentation about Result.from_path due to being at the time unsupported by Train v2 API. Now that it has been implemented #58216, we can uncomment this documentation for users.

Signed-off-by: Mark Towers <mark@anyscale.com>
@pseudo-rnd-thoughts pseudo-rnd-thoughts requested a review from a team as a code owner April 23, 2026 16:30
@pseudo-rnd-thoughts pseudo-rnd-thoughts added docs An issue or change related to documentation train Ray Train Related Issue go add ONLY when ready to merge, run all tests labels Apr 23, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the documentation and example code for restoring training results from a path using Result.from_path. It uncomments the relevant Python code in key_concepts.py and the corresponding documentation block in results.rst. A review comment correctly identifies that the example print statement should use the newly created restored_result variable instead of the original result variable to properly demonstrate the feature.

Comment thread doc/source/train/doc_code/key_concepts.py Outdated
Signed-off-by: Mark Towers <mark@anyscale.com>
@justinvyu justinvyu enabled auto-merge (squash) April 23, 2026 16:39
@pseudo-rnd-thoughts pseudo-rnd-thoughts added go add ONLY when ready to merge, run all tests and removed go add ONLY when ready to merge, run all tests labels Apr 24, 2026
@justinvyu justinvyu merged commit d602dd7 into ray-project:master Apr 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs An issue or change related to documentation go add ONLY when ready to merge, run all tests train Ray Train Related Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants