[Serve] Simplify background thread deployment method invocation test pattern#62940
Merged
Merged
Conversation
…pattern Signed-off-by: win5923 <ken89@kimo.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the gang scheduling tests by replacing manual background thread management with the non-blocking _blocking=False parameter in serve._run. This change streamlines the test logic by removing the need for explicit thread creation and joining. I have no feedback to provide.
ray-gardener
Bot
added
serve
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
github-actions
Bot
added
stale
abrarsheikh
approved these changes
May 15, 2026
TruongQuangPhat
pushed a commit
to cyhapun/ray-fix-issue
that referenced
this pull request
May 27, 2026
…pattern (ray-project#62940) ## Description See ray-project#61797 ## Related issues Closes ray-project#61797 ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. Signed-off-by: win5923 <ken89@kimo.com> Signed-off-by: phattruong <23120318@student.hcmus.edu.vn>
Neelansh-Khare
pushed a commit
to Neelansh-Khare/ray-clone
that referenced
this pull request
Jun 5, 2026
…pattern (ray-project#62940) ## Description See ray-project#61797 ## Related issues Closes ray-project#61797 ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. Signed-off-by: win5923 <ken89@kimo.com> Signed-off-by: Neelansh Khare <kharen@uci.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #61797
Related issues
Closes #61797
Additional information