[deps] Ray py3.14 dependencies and requirements for image building#63080
Conversation
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces initial support for Python 3.14 by updating the CI dependency configurations and adding a compiled requirements file. Feedback indicates that the new lock file likely wasn't re-compiled correctly for Python 3.14, as it contains environment markers that exclude the version and references Python 3.13 source paths. Additionally, the CI configuration should be expanded to include Python 3.14 in other dependency sets for project-wide consistency.
| # via msrestazure | ||
| adlfs==2026.4.0 | ||
| # via -r python/requirements/cloud-requirements.txt | ||
| aim==3.23.0 ; python_version < "3.12" |
There was a problem hiding this comment.
This lock file contains packages with environment markers that explicitly exclude Python 3.14 (e.g., aim==3.23.0 ; python_version < "3.12"). This indicates that the file was likely copied from an older Python version's lock file and not correctly re-compiled for 3.14 using uv pip compile --python-version 3.14.
| # -r python/requirements/ml/py313/core-requirements.txt | ||
| # -r python/requirements/ml/py313/train-requirements.txt |
There was a problem hiding this comment.
The # via comments in this file reference Python 3.13 requirement paths (e.g., python/requirements/ml/py313/core-requirements.txt). For a Python 3.14 lock file, these should point to the corresponding 3.14 requirement files to ensure dependency correctness and parity across environments.
| py314: | ||
| PYTHON_VERSION: "3.14" | ||
| PYTHON_SHORT: "314" |
There was a problem hiding this comment.
The py314 build argument set is only being used by ray_img_depset. To provide consistent Python 3.14 support across the project, it should also be added to the build_arg_sets of other depsets in this file, such as ray_base_extra_testdeps, ray_base_slim, and ray_base_deps.
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
changed the title
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn
changed the title
| rm /tmp/miniforge.sh | ||
| $HOME/anaconda3/bin/conda install -y libgcc-ng python=$PYTHON_VERSION | ||
| $HOME/anaconda3/bin/conda install -y -c conda-forge libffi=3.4.2 | ||
| $HOME/anaconda3/bin/conda install -y -c conda-forge libffi=3.4.6 |
There was a problem hiding this comment.
why libffi change is required?
There was a problem hiding this comment.
python 3.14.0 requires libffi >=3.4.6,<3.5.
There was a problem hiding this comment.
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
…ay-project#63080) generating py3.14 lock file and allowing for py3.14 image builds --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
…ay-project#63080) generating py3.14 lock file and allowing for py3.14 image builds --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com> Signed-off-by: anindyam1969 <amukherjee@kinetica.com>
…ay-project#63080) generating py3.14 lock file and allowing for py3.14 image builds --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
2 participants
generating py3.14 lock file and allowing for py3.14 image builds