Improve hash partition for columns contains Struct/list/map#63152
Open
laysfire wants to merge 3 commits into
Open
Improve hash partition for columns contains Struct/list/map#63152laysfire wants to merge 3 commits into
laysfire wants to merge 3 commits into
Conversation
Signed-off-by: yifan.xie <xyfabcd@163.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request optimizes the row-by-row hashing logic in _hash_partition by replacing manual column indexing with a more efficient enumerate(zip(*table.columns)) approach. This change improves code readability and potentially performance when processing unhashable PyArrow columns. I have no feedback to provide as there are no review comments.
Contributor
Author
|
@owenowenisme hi, could you help review? |
owenowenisme
approved these changes
May 16, 2026
Member
owenowenisme
left a comment
There was a problem hiding this comment.
Great improvement! Could you add comments explaining this improvement in the code?
Signed-off-by: yifan.xie <xyfabcd@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr is to improve hash partition performance when table contains pandas can't handle types by moving retrieve table columns operations out of loop.
Use the following script to verify:
The test result is:
Related issues