[serve] Fix AttributeError when request_router is None in update_deployment_config#63180
Merged
abrarsheikh merged 2 commits intoMay 8, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a potential AttributeError in AsyncioRouter.update_deployment_config by ensuring the request_router is initialized before accessing its replicas. It also includes regression tests for various initialization states. The review feedback identifies a need to explicitly shut down AsyncioRouter instances in the new tests to prevent background task leaks.
Contributor
Author
|
Thanks for the review! I've addressed all three Medium Priority comments in the follow-up commit Each of the three test cases in await router.shutdown()
router.long_poll_client.stop()after the assertion, consistent with the teardown pattern in the existing |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 87306cc. Configure here.
ray-gardener
Bot
added
serve
…nfig
When AsyncioRouter.update_deployment_config() is called before the
request_router has been lazily initialised (e.g. request_router_class
is None, or the first config update arrives before any replica is
assigned), the self.request_router property returns None.
The previous code unconditionally evaluated:
len(self.request_router.curr_replicas)
which raises AttributeError: 'NoneType' object has no attribute
'curr_replicas'.
Fix: cache the property result in a local variable and fall back to 0
when it is None. Zero is semantically correct because no replicas are
active at that point, so MetricsManager should not trigger a
scaled-to-zero optimised push.
Signed-off-by: chenshi5012 <chenshi5012@163.com>
chenshi5012
force-pushed
the
fix/serve-router-null-deref-update-deployment-config
branch
from
87306cc to
4a013be
Compare
Contributor
Author
|
@cursoragent review again |
|
Unable to authenticate your request. Please make sure to connect your GitHub account to Cursor. Go to Cursor |
abrarsheikh
approved these changes
May 7, 2026
chillCode404
pushed a commit
to chillCode404/ray-contrib
that referenced
this pull request
May 9, 2026
…oyment_config (ray-project#63180) ## Description `AsyncioRouter.update_deployment_config()` unconditionally evaluates `len(self.request_router.curr_replicas)` at the end of the method. The `request_router` property performs lazy initialisation and returns `None` when `_request_router_class` is `None` and `_request_router` has not yet been initialised. In that state the call raises: ``` AttributeError: 'NoneType' object has no attribute 'curr_replicas' ``` **Trigger conditions** 1. `AsyncioRouter` is constructed without a `request_router_class` (the parameter is `Optional`), and the Controller's first long-poll config push arrives before any replica is assigned — the lazy-init path is never entered, so the property returns `None`. 2. A live deployment is hot-updated to remove a custom `request_router_class`; `update_deployment_config()` overwrites `self._request_router_class` with the new value before the guard `if self._request_router:` is evaluated, leaving both fields `None`. 3. Race condition: the Controller pushes a new config between construction and the first call to `assign_request()` that would trigger lazy init. **Fix** Cache the property result in a local variable and fall back to `0` when it is `None`. Zero is semantically correct: no replicas are active yet, so `MetricsManager` should not trigger a scaled-to-zero optimised push. ```python # before curr_num_replicas=len(self.request_router.curr_replicas), # after _router = self.request_router curr_num_replicas = len(_router.curr_replicas) if _router is not None else 0 ``` ## Related issues None — this is a self-contained bug fix. ## Checks - [x] I've signed off every commit with `Signed-off-by` - [x] I've run `scripts/format.sh` to lint the changes in this PR - [x] I've included any doc changes needed for this PR Signed-off-by: chenshi5012 <chenshi5012@163.com>
dancingactor
pushed a commit
to dancingactor/ray
that referenced
this pull request
May 13, 2026
…oyment_config (ray-project#63180) ## Description `AsyncioRouter.update_deployment_config()` unconditionally evaluates `len(self.request_router.curr_replicas)` at the end of the method. The `request_router` property performs lazy initialisation and returns `None` when `_request_router_class` is `None` and `_request_router` has not yet been initialised. In that state the call raises: ``` AttributeError: 'NoneType' object has no attribute 'curr_replicas' ``` **Trigger conditions** 1. `AsyncioRouter` is constructed without a `request_router_class` (the parameter is `Optional`), and the Controller's first long-poll config push arrives before any replica is assigned — the lazy-init path is never entered, so the property returns `None`. 2. A live deployment is hot-updated to remove a custom `request_router_class`; `update_deployment_config()` overwrites `self._request_router_class` with the new value before the guard `if self._request_router:` is evaluated, leaving both fields `None`. 3. Race condition: the Controller pushes a new config between construction and the first call to `assign_request()` that would trigger lazy init. **Fix** Cache the property result in a local variable and fall back to `0` when it is `None`. Zero is semantically correct: no replicas are active yet, so `MetricsManager` should not trigger a scaled-to-zero optimised push. ```python # before curr_num_replicas=len(self.request_router.curr_replicas), # after _router = self.request_router curr_num_replicas = len(_router.curr_replicas) if _router is not None else 0 ``` ## Related issues None — this is a self-contained bug fix. ## Checks - [x] I've signed off every commit with `Signed-off-by` - [x] I've run `scripts/format.sh` to lint the changes in this PR - [x] I've included any doc changes needed for this PR Signed-off-by: chenshi5012 <chenshi5012@163.com>
am-kinetica
pushed a commit
to kineticadb/ray
that referenced
this pull request
May 14, 2026
…oyment_config (ray-project#63180) ## Description `AsyncioRouter.update_deployment_config()` unconditionally evaluates `len(self.request_router.curr_replicas)` at the end of the method. The `request_router` property performs lazy initialisation and returns `None` when `_request_router_class` is `None` and `_request_router` has not yet been initialised. In that state the call raises: ``` AttributeError: 'NoneType' object has no attribute 'curr_replicas' ``` **Trigger conditions** 1. `AsyncioRouter` is constructed without a `request_router_class` (the parameter is `Optional`), and the Controller's first long-poll config push arrives before any replica is assigned — the lazy-init path is never entered, so the property returns `None`. 2. A live deployment is hot-updated to remove a custom `request_router_class`; `update_deployment_config()` overwrites `self._request_router_class` with the new value before the guard `if self._request_router:` is evaluated, leaving both fields `None`. 3. Race condition: the Controller pushes a new config between construction and the first call to `assign_request()` that would trigger lazy init. **Fix** Cache the property result in a local variable and fall back to `0` when it is `None`. Zero is semantically correct: no replicas are active yet, so `MetricsManager` should not trigger a scaled-to-zero optimised push. ```python # before curr_num_replicas=len(self.request_router.curr_replicas), # after _router = self.request_router curr_num_replicas = len(_router.curr_replicas) if _router is not None else 0 ``` ## Related issues None — this is a self-contained bug fix. ## Checks - [x] I've signed off every commit with `Signed-off-by` - [x] I've run `scripts/format.sh` to lint the changes in this PR - [x] I've included any doc changes needed for this PR Signed-off-by: chenshi5012 <chenshi5012@163.com> Signed-off-by: anindyam1969 <amukherjee@kinetica.com>
Lucas61000
pushed a commit
to Lucas61000/ray
that referenced
this pull request
May 15, 2026
…oyment_config (ray-project#63180) ## Description `AsyncioRouter.update_deployment_config()` unconditionally evaluates `len(self.request_router.curr_replicas)` at the end of the method. The `request_router` property performs lazy initialisation and returns `None` when `_request_router_class` is `None` and `_request_router` has not yet been initialised. In that state the call raises: ``` AttributeError: 'NoneType' object has no attribute 'curr_replicas' ``` **Trigger conditions** 1. `AsyncioRouter` is constructed without a `request_router_class` (the parameter is `Optional`), and the Controller's first long-poll config push arrives before any replica is assigned — the lazy-init path is never entered, so the property returns `None`. 2. A live deployment is hot-updated to remove a custom `request_router_class`; `update_deployment_config()` overwrites `self._request_router_class` with the new value before the guard `if self._request_router:` is evaluated, leaving both fields `None`. 3. Race condition: the Controller pushes a new config between construction and the first call to `assign_request()` that would trigger lazy init. **Fix** Cache the property result in a local variable and fall back to `0` when it is `None`. Zero is semantically correct: no replicas are active yet, so `MetricsManager` should not trigger a scaled-to-zero optimised push. ```python # before curr_num_replicas=len(self.request_router.curr_replicas), # after _router = self.request_router curr_num_replicas = len(_router.curr_replicas) if _router is not None else 0 ``` ## Related issues None — this is a self-contained bug fix. ## Checks - [x] I've signed off every commit with `Signed-off-by` - [x] I've run `scripts/format.sh` to lint the changes in this PR - [x] I've included any doc changes needed for this PR Signed-off-by: chenshi5012 <chenshi5012@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AsyncioRouter.update_deployment_config()unconditionally evaluateslen(self.request_router.curr_replicas)at the end of the method.The
request_routerproperty performs lazy initialisation and returnsNonewhen_request_router_classisNoneand_request_routerhas not yet been initialised. In that state the call raises:
Trigger conditions
AsyncioRouteris constructed without arequest_router_class(theparameter is
Optional), and the Controller's first long-poll configpush arrives before any replica is assigned — the lazy-init path is
never entered, so the property returns
None.request_router_class;update_deployment_config()overwritesself._request_router_classwith the new value before the guardif self._request_router:is evaluated, leaving both fieldsNone.and the first call to
assign_request()that would trigger lazy init.Fix
Cache the property result in a local variable and fall back to
0whenit is
None. Zero is semantically correct: no replicas are active yet,so
MetricsManagershould not trigger a scaled-to-zero optimised push.Related issues
None — this is a self-contained bug fix.
Checks
Signed-off-byscripts/format.shto lint the changes in this PR