Skip to content

[docs] GKE TPU guide: Fix var, add TPU types per legion link#63209

Merged
edoakes merged 3 commits into
ray-project:masterfrom
spencer-p:tpu-doc
May 26, 2026
Merged

[docs] GKE TPU guide: Fix var, add TPU types per legion link#63209
edoakes merged 3 commits into
ray-project:masterfrom
spencer-p:tpu-doc

Conversation

@spencer-p
Copy link
Copy Markdown
Contributor

Description

  • The guide sets up a COMPUTE_ZONE environment variable which is later referenced as $ZONE. Changed to use ZONE consistently.
  • There is a note about the TPU v4 location -- added a link to TPU regions and zones next to it for users trying other types.

Related issues

none

Additional information

none

Signed-off-by: Spencer Peterson <spencerjp@google.com>
@spencer-p spencer-p requested a review from a team as a code owner May 7, 2026 20:39
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GKE TPU cluster documentation by renaming the ZONE environment variable placeholder and adding a reference for other TPU types. The reviewer suggested improving consistency by using 'ZONE' as the placeholder value and using a standard URL format for the TPU locations link.

Comment thread doc/source/cluster/kubernetes/user-guides/gcp-gke-tpu-cluster.md Outdated
Comment thread doc/source/cluster/kubernetes/user-guides/gcp-gke-tpu-cluster.md
Copy link
Copy Markdown
Contributor

@ryanaoleary ryanaoleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the two gemini comments are resolved

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Spencer Peterson <spencerjp@google.com>
@ryanaoleary ryanaoleary enabled auto-merge (squash) May 8, 2026 01:16
@github-actions github-actions Bot added the go add ONLY when ready to merge, run all tests label May 8, 2026
@ray-gardener ray-gardener Bot added train Ray Train Related Issue core Issues that should be addressed in Ray Core community-contribution Contributed by the community labels May 8, 2026
@github-actions github-actions Bot disabled auto-merge May 8, 2026 22:01
@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions Bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label May 23, 2026
@ryanaoleary
Copy link
Copy Markdown
Contributor

not stale, cc: @edoakes needs core team review

@github-actions github-actions Bot added unstale A PR that has been marked unstale. It will not get marked stale again if this label is on it. and removed stale The issue is stale. It will be closed within 7 days unless there are further conversation labels May 23, 2026
@edoakes edoakes merged commit 1a41260 into ray-project:master May 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contributed by the community core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests train Ray Train Related Issue unstale A PR that has been marked unstale. It will not get marked stale again if this label is on it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants