[WIP][Do not merge] Populating if actor is detached actor or not in TaskEvents proto#63262
Draft
karticam wants to merge 1 commit into
Draft
[WIP][Do not merge] Populating if actor is detached actor or not in TaskEvents proto#63262karticam wants to merge 1 commit into
karticam wants to merge 1 commit into
Conversation
karticam
changed the title
karticam
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new is_detached_actor boolean field to the TaskInfoEntry and TaskDefinitionEvent protobuf messages. The changes include updating the logic in protobuf_utils.cc, task_event_buffer.cc, and gcs_ray_event_converter.cc to ensure this field is correctly populated for detached actor creation tasks. I have no feedback to provide as there were no review comments.
karticam
force-pushed
the
karticam/detach-actor-diff
branch
from
1b063f7 to
3bd254a
Compare
Signed-off-by: Kartica Modi <karticamodi@gmail.com>
karticam
force-pushed
the
karticam/detach-actor-diff
branch
from
3bd254a to
d3c8339
Compare
karticam
added
core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Additional information