Skip to content

[Data] Display logical memory in progress bar#63379

Merged
bveeramani merged 4 commits into
masterfrom
add-logical-memory-progress-bar
May 15, 2026
Merged

[Data] Display logical memory in progress bar#63379
bveeramani merged 4 commits into
masterfrom
add-logical-memory-progress-bar

Conversation

@bveeramani
Copy link
Copy Markdown
Member

@bveeramani bveeramani commented May 15, 2026

Description

The Ray Data progress bar shows CPU, GPU, and object store memory usage, but not logical memory — even though ExecutionResources already tracks it and operators already report it via current_logical_usage(). This makes it hard to monitor memory-constrained workloads. This PR adds logical memory to both the global resource status line and per-operator usage strings, displayed conditionally when usage is non-zero (matching the existing GPU pattern).

Related issues

None.

Additional information

The display order is: CPU, memory, GPU, object store. Memory is only shown when usage > 0, consistent with how GPU is handled.

Example global status line:

Active & requested resources: 4/8 CPU, 2.0GiB/8.0GiB memory, 1/2 GPU, 1.0GiB/2.0GiB object store

The progress bar already shows CPUs, GPUs, and object store memory, but
not logical memory — even though ExecutionResources tracks it and
operators report it. Add logical memory to both the global resource
status line and per-operator usage strings, conditional on non-zero
usage.

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani bveeramani requested a review from a team as a code owner May 15, 2026 21:30
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates memory usage reporting into the Ray Data execution framework. It updates ResourceManager to include memory metrics in operator usage, allocations, and budgets, and refactors StreamingExecutor to include memory in its resource status reports. No review comments were provided, so I have no feedback to offer.

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani bveeramani enabled auto-merge (squash) May 15, 2026 22:16
@github-actions github-actions Bot added the go add ONLY when ready to merge, run all tests label May 15, 2026
@bveeramani bveeramani merged commit 3ba1602 into master May 15, 2026
7 of 8 checks passed
@bveeramani bveeramani deleted the add-logical-memory-progress-bar branch May 15, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants